Closed Bug 385132 Opened 17 years ago Closed 17 years ago

Huge width/height resulting from "padding: 100%", table

Categories

(Core :: Layout: Tables, defect)

x86
All
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: jruderman, Assigned: dholbert)

References

Details

(Keywords: assertion, testcase)

Attachments

(2 files)

Attached file testcase (deleted) —
###!!! ASSERTION: assigned width smaller than min: 'col_width >= colFrame->GetMinCoord()', file /Users/jruderman/trunk/mozilla/layout/tables/BasicTableLayoutStrategy.cpp, line 960

###!!! ASSERTION: didn't subtract all that we added: 'space == 0 && ((l2t == FLEX_PCT_LARGE) ? (-0.001f < basis.f && basis.f < 0.001f) : (basis.c == 0))', file /Users/jruderman/trunk/mozilla/layout/tables/BasicTableLayoutStrategy.cpp, line 972

###!!! ASSERTION: bad width: 'Not Reached', file /Users/jruderman/trunk/mozilla/layout/generic/nsLineLayout.cpp, line 180

###!!! ASSERTION: Computed overflow area must contain frame bounds: 'aNewSize.width == 0 || aNewSize.height == 0 || aOverflowArea->Contains(nsRect(nsPoint(0, 0), aNewSize))', file /Users/jruderman/trunk/mozilla/layout/generic/nsFrame.cpp, line 5317
Attached file reduced testcase (deleted) —
Simplified the test case a bit.

Problem occurs for values of padding >= 50%.  

I'm not totally familiar with padding, but it seems like the problem happens because we've got two divs in the same row that are each trying to take up over half of the row.
Hmm, the new testcase triggers width-related assertions but doesn't make scrollbars appear.
oops, Jesse's right -- my second testcase only triggers the first two assertions.  

Maybe that will make that section of the problem easier to debug, in any case.
OS: Mac OS X → All
Depends on: 385533
Filed a separate bug for my reduced testcase, which triggers the first 2 assertions only: bug 385533
My first patch for bug 385533 (attachment 269715 [details] [diff] [review]) fixes this bug's testcases.  (Just posted the patch, so it hasn't yet been reviewed)
Status: NEW → ASSIGNED
I posted an nscoord_MAX-checking patch on bug 367673, and it covers this bug as
well.
Depends on: 367673
Assignee: nobody → dholbert
Status: ASSIGNED → NEW
Status: NEW → ASSIGNED
Fixed by checkin for bug 367673.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Flags: in-testsuite?
Crashtests checked in.  They don't check for huge widths/heights, but they do check for the resulting assertions.
Flags: in-testsuite? → in-testsuite+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: