Closed Bug 385518 Opened 18 years ago Closed 18 years ago

SQLite build break after update to 3.3.17

Categories

(Toolkit :: Storage, defect)

x86
OS/2
defect
Not set
critical

Tracking

()

RESOLVED FIXED

People

(Reporter: mozilla, Assigned: mozilla)

Details

Attachments

(1 file)

Attached patch SQLite build fix (deleted) — Splinter Review
Compiling or linking sqlite3/storage is broken on OS/2 since bug 341137 went in, at least when high memory is enabled (also see bug 217538 comment 31). I guess that is why the nightly builds are all broken at the moment. This patch should fix that. I have just checked it into SQLite CVS upstream, too, so that will be in SQLite 3.4.1 and hopefully appear with the next SQLite sync.
Attachment #269431 - Flags: review?(mozilla)
Was there a ticket filed for this upstream? I'm just trying to do good bookkeeping here :)
No, I just checked it in directly, checkins 4109 and 4110: http://www.sqlite.org/cvstrac/chngview?cn=4109 http://www.sqlite.org/cvstrac/chngview?cn=4110 SQLite doesn't have a review system like Mozilla does, so filing tickets is not really necessary for small changes like these...
Attachment #269431 - Flags: review?(mozilla) → review+
Fix checked into trunk.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Summary: SQLite build break after → SQLite build break after update to 3.3.17
Peter, I also recognized the build break due to the sqlite update last week. As I hadn't the time to trace it down, I remember that I wondered why it broke, because the highmem related lines were present also in the amalgamation file. After your checkin, the lines around http://lxr.mozilla.org/seamonkey/source/db/sqlite3/src/sqlite3.c#10481 are present twice. Probably the build failure in highmem builds after the checkin of the original patch were due to the wrong order of os2.h and os2safe.h. Maybe you want to remove the doubled lines.
Will do that in SQLite upstream, trying to include it twice doesn't hurt.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: