Closed
Bug 385544
Opened 18 years ago
Closed 17 years ago
32 bit build of breakpad fails on a x86_64 Linux system
Categories
(Toolkit :: Crash Reporting, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: wgianopoulos, Unassigned)
References
Details
Attachments
(1 file)
(deleted),
patch
|
ted
:
review-
|
Details | Diff | Splinter Review |
Attempting to build a 32-bit version of Firefox on a Fedora Core 6 system with an AMD 64bit process fails here:
c++ -o nsHTMLSharedElement.o -c -I../../../../dist/include/system_wrappers -include /home/wag/mozilla/trunk/config/gcc_hidden.h -DMOZILLA_INTERNAL_API -DOSTYPE=\"Linux2.6.18-1.2869\" -DOSARCH=Linux -DBUILD_ID=2007062214 -D_IMPL_NS_LAYOUT -I../../../../dist/include/xpcom -I../../../../dist/include/string -I../../../../dist/include/gfx -I../../../../dist/include/layout -I../../../../dist/include/widget -I../../../../dist/include/dom -I../../../../dist/include/js -I../../../../dist/include/locale -I../../../../dist/include/unicharutil -I../../../../dist/include/webshell -I../../../../dist/include/uriloader -I../../../../dist/include/htmlparser -I../../../../dist/include/necko -I../../../../dist/include/view -I../../../../dist/include/pref -I../../../../dist/include/docshell -I../../../../dist/include/xpconnect -I../../../../dist/include/xuldoc -I../../../../dist/include/caps -I../../../../dist/include/editor -I../../../../dist/include/imglib2 -I../../../../dist/include/mimetype -I../../../../dist/include/exthandler -I../../../../dist/include/uconv -I../../../../dist/include/intl -I../../../../dist/include/plugin -I../../../../dist/include -I../../../../dist/include/content -I../../../../dist/include/nspr -DMOZ_PNG_READ -DMOZ_PNG_WRITE -I../../../../dist/sdk/include -I/home/wag/mozilla/trunk/content/html/content/src/../../../base/src -I/home/wag/mozilla/trunk/content/html/content/src/../../../events/src -I/home/wag/mozilla/trunk/content/html/content/src/../../../xbl/src -I/home/wag/mozilla/trunk/content/html/content/src/../../../../layout/style -I/home/wag/mozilla/trunk/content/html/content/src -fno-rtti -fno-excepti
[wag@localhost ~]$ tail build.out
gmake[5]: Leaving directory `/home/wag/mozilla/trunk/fx32-obj/toolkit/airbag'
gmake[4]: *** [libs] Error 2
gmake[4]: Leaving directory `/home/wag/mozilla/trunk/fx32-obj/toolkit'
gmake[3]: *** [libs_tier_toolkit] Error 2
gmake[3]: Leaving directory `/home/wag/mozilla/trunk/fx32-obj'
gmake[2]: *** [tier_toolkit] Error 2
gmake[2]: Leaving directory `/home/wag/mozilla/trunk/fx32-obj'
make[1]: *** [default] Error 2
make[1]: Leaving directory `/home/wag/mozilla/trunk/fx32-obj'
make: *** [build] Error 2
Reporter | ||
Comment 1•18 years ago
|
||
The cause of this is that exception_handler.cc includes both signal.h and asm/sigcontext.h. However, signal.h includes bits/sigcontext.h. Documentation seems to indicate that you should not include sigcontext.h, but include signal.h instead.
I also changed minidump_generator.cc to include stdio.h instead of asm/sigcontext.h.
With this patch the build goes to completion, but I have no way of testing if it actually will send correct crash data. I also have no way to test if this will build correctly on a 32 bit processor linux system or on other distributions.
Attachment #269461 -
Flags: review?
Reporter | ||
Updated•18 years ago
|
Attachment #269461 -
Flags: review? → review?(ted.mielczarek)
Comment 2•18 years ago
|
||
Comment on attachment 269461 [details] [diff] [review]
possible fix
It's gonna take more than that to make Breakpad work on x86_64, and we don't take patches to Breakpad here, we only take them upstream.
Attachment #269461 -
Flags: review?(ted.mielczarek) → review-
Comment 3•18 years ago
|
||
Duping this over, we really just want a patch to disable building Breakpad on x86_64.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → DUPLICATE
Reporter | ||
Comment 4•18 years ago
|
||
The intention of this patch was not to create a 64-bit build with breakpad. The intention was to permit building a 32 bit version of firefox including breakpad but doing the build using the 32-bit build tools on a 64 bit system.
Duping it to that bug 385398 is really not correct. That bug is about trying to build a Linux 64-bit binary that includes breakpad, which is really a completely seperate issue.
If you don't want to fix this, then it would be more correct to mark it WONTFIX than to dupe it to a bug about something that is really not the same.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Comment 5•18 years ago
|
||
Ok, I apparently didn't read your bug right. Sorry! Can you file an issue in Breakpad's issue tracker, and prepare a patch against Breakpad SVN? If we get it in upstream, we can merge back down here.
http://code.google.com/p/google-breakpad/issues/list
Reporter | ||
Comment 6•18 years ago
|
||
OK filed issue 190.
http://code.google.com/p/google-breakpad/issues/detail?id=190
Comment 7•17 years ago
|
||
I think this got fixed when I merged in bug 386632.
Status: REOPENED → RESOLVED
Closed: 18 years ago → 17 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•