Andrew Schultz Reporter
	Description • 17 years ago

With crash reporter enabled, if I try to invoke "seamonkey -register" I get

./seamonkey-bin: error while loading shared libraries: ./libxul.so: cannot restore segment prot after reloc: Permission denied

This fails on nye if I don't disable the ac_cv_visibility_* flags (they're explicitly disabled on nye bloat).  nye is FC6 using gcc 4.1.1.  I also see this on my desktop building with F7's gcc 4.1.2.

	Andrew Schultz Reporter
	Comment 1 • 17 years ago

I get the same problem with the 6/22 nightly from the cb-sea-linux-tbox.  Conceivably, the official Mozilla tinderboxes themselves are not hitting this because they have selinux disabled.

	Benjamin Smedberg
	Comment 2 • 17 years ago

This is ok with the Firefox nightly builds? Can you determine which symbol references are using textrels?

This is almost certainly the GCC 4.1 visibility bug, which doesn't affect the linux refplatform because we're using a custom GCC with the bug fixed. Hopefully this would also be fixed using GCC 4.2

	Andrew Schultz Reporter
	Comment 3 • 17 years ago

I also see this with latest the firefox nightly

% eu-findtextrel libxul.so | sort -u
either the file containing the function '_ZNSt6vectorIPN15google_breakpad16ExceptionHandlerESaIS2_EE9push_backERKS2_' or the file containing the function '_ZNKSt6vectorItSaItEE5emptyEv' is not compiled with -fpic/-fPIC

	Benjamin Smedberg
	Comment 4 • 17 years ago

yeah, we need FORCE_USE_PIC in the appropriate makefiles

airbag/airbag/src/common
airbag/airbag/src/common/linux
airbag/airbag/src/client
airbag/airbag/src/client/linux/handler
airbag/airbag/src/tools/linux/dump_syms

and perhaps airbag/client

	(not currently active) Ted Mielczarek
	Comment 6 • 17 years ago

Comment on attachment 269529 [details] [diff] [review]
FORCE_USE_PIC on liux

>Index: toolkit/airbag/airbag/src/client/Makefile.in
>===================================================================
>+FORCE_USE_PIC = 1

>Index: toolkit/airbag/airbag/src/common/Makefile.in
>===================================================================
>+FORCE_USE_PIC = 1

This doesn't do anything bad on Mac, does it?

Otherwise, r=me

	Andrew Schultz Reporter
	Comment 7 • 17 years ago

Any idea why the MoCo tinderboxen did not go orange because of this?  Do they run with selinux disabled?

	Dave Camp (:dcamp) Assignee
	Comment 8 • 17 years ago

checked in

	Andrew Schultz Reporter
	Comment 9 • 17 years ago

the patch had no apparent effect.  See the "nye cairo" box on MozillaTest

An up to date build with symbols:

eu-findtextrel libxul.so
/build/andrew/smopt/mozilla/toolkit/airbag/airbag/src/client/linux/handler/linux_thread.cc not compiled with -fpic/-fPIC
(this is clearly a lie, but...)

	Benjamin Smedberg
	Comment 10 • 17 years ago

This was probably fixed by bug 385692 which I just checked in. Can somebody verify later today?

	Andrew Schultz Reporter
	Comment 11 • 17 years ago

Yes, that fixed it.  I also tried backing out the fPIC patch and I still get no text relocations.

	Benjamin Smedberg
	Comment 12 • 17 years ago

I'd like to keep the FORCE_USE_PIC patch in because I believe it is necessary in Firefox static builds, which aren't deprecated yet.