The non-Cairo code in nsWindow.cpp is outdated and should be removed. Note, that for example image decoders also don't have non-cairo support anymore.

In windows/nsWindow.cpp there are three local/static functions that are only referred by the non-Cairo code, and can therefor also be removed. So, now this not just clean source code, but also reduces compiled code size (about ± 1.5K).

Comment on attachment 269887 [details] [diff] [review] V2: Do windows and OS/2 and remove now redundant static functions Couldn't you just remove UpdateTranslucentWindowAlphaInner (and the call to it in UpdateTranslucentWindowAlpha)? r=me for the Windows part, OS/2 is out of my scope (it's been like 8 years since I've used it...).

(In reply to comment #3) > r=me for the Windows part, OS/2 is out of my scope (it's been like 8 years > since I've used it...). > Just FYI, there is bug 389729 filed that would also cover the OS/2 files in this attachment. This bug is about removal of non-Cairo code from all OS/2 files. So, maybe here you should take care only of the windows files or communicate changes in OS/2 files to bug 389729.

Bug 389729 contains the exact same changes to OS/2's nsWindow. Please get this one in without the OS/2 bits.

I'll remove the OS/2 bits soon and upload a new patch.

dbaron, third part of the set of non-Cairo removal.

roc would be a better reviewer for this; you might want to ask biesi about the cursor parts. It's not clear to me whether this is code that should work with cairo but hasn't been made to work with it yet, or whether it's really code we don't want anymore.

Comment on attachment 275575 [details] [diff] [review] V3: Update to trunk, and only do the Windows part This code al does work in Cairo. It just that the non-Cairo code is no longer needed, and some functions (Data8BitTo1Bit, DataToAData, and CreateOpaqueAlphaChannel) are no longer needed in the Cairo version.

yeah, those functions can be removed now.

Who can do the checkin? Thanks in advance!

Per the top of the tinderbox and http://groups.google.com/group/mozilla.dev.planning/browse_thread/thread/f569a23ce266a451/265344ae5291dee0 your patch needs approval1.9+ before anyone can do the checkin.

Who can do the checkin for me, now that approval1.9+ has been given? Thanks in advance!

Checked into trunk.

Thanks!