Closed Bug 385891 Opened 17 years ago Closed 17 years ago

Removal of non-Cairo code from nsFrame.cpp and nsObjectFrame.cpp

Categories

(Core :: Graphics, defect)

Product:
Core
Component:
Graphics
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: alfredkayser, Assigned: alfredkayser)

References

Details

Attachments

(1 file, 2 obsolete files)

Really kill all traces of SelectionImage
(deleted), patch
Details | Diff | Splinter Review
Attached patch Patch to remove the non-cairo stuff (obsolete) (deleted) — — Splinter Review
Removal of non-Cairo code from nsFrame.cpp and nsObjectFrame.cpp as the non-Cairo graphics are no longer supported (e.g. the image decoders don't do non-Cairo anymore).
Attachment #269822 - Flags: review?(vladimir)
Blocks: 367281
Comment on attachment 269822 [details] [diff] [review] Patch to remove the non-cairo stuff dbaron, can you r/sr this? This is a simple removal of non-Cairo stuff, which allows me to clean gfxImageFrame. Thanks, Alfred
Attachment #269822 - Flags: review?(vladimir) → review?(dbaron)
Do we actually not want this behavior anymore, or did we just disable it because it didn't work with cairo (yet)? I don't see why it's blocking other work, though, since it won't break anybody's build.
(In reply to comment #2) > Do we actually not want this behavior anymore, or did we just disable it > because it didn't work with cairo (yet)? The nsFrame code is really dead; both branches of the #ifndef MOZ_CAIRO_GFX in nsDisplaySelectionOverlay::Paint do exactly the same thing.
It is not literally blocking other work, but the non-Cairo refers to some G/SetAlpha functions that I want to remove from gfxImageFrame, and I want to have all references to those functions removed the tree, before cleaning gfxImageFrame.
Comment on attachment 269822 [details] [diff] [review] Patch to remove the non-cairo stuff OK, this is ok, except could you post another patch that also: * cvs removes nsISelectionImageService.idl * removes the nsISelectionImageService code from nsPresContext.cpp and nsLayoutModule.cpp
Attachment #269822 - Flags: review?(dbaron) → review-
Attached patch V2: KIll nsISelectionImageService completely (obsolete) (deleted) — — Splinter Review
Assignee: nobody → alfredkayser
Attachment #269822 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #276679 - Flags: review?(dbaron)
Comment on attachment 276679 [details] [diff] [review] V2: KIll nsISelectionImageService completely r+sr+a1.9=dbaron
Attachment #276679 - Flags: superreview+
Attachment #276679 - Flags: review?(dbaron)
Attachment #276679 - Flags: review+
Attachment #276679 - Flags: approval1.9+
Keywords: checkin-needed
Your forget one changes in nsLayoutModule.cpp which is #ifndef MOZ_CAIRO_GFX { "selection image storage", NS_SELECTIONIMAGESERVICE_CID, nsnull, CreateSelectionImageService }, #endif
Attachment #276679 - Attachment is obsolete: true
Checked into trunk.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Thanks!
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: