Closed
Bug 386009
Opened 17 years ago
Closed 17 years ago
nsEditor leaks an nsAString
Categories
(Core :: DOM: Editor, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: sayrer, Assigned: sayrer)
Details
(Keywords: memory-leak)
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
dbaron
:
review+
dbaron
:
superreview+
|
Details | Diff | Splinter Review |
|
Assignee | |
Comment 1•17 years ago
|
||
Assignee: nobody → sayrer
Status: NEW → ASSIGNED
Attachment #269974 -
Flags: superreview?(dbaron)
Attachment #269974 -
Flags: review?(dbaron)
|
||
Comment 2•17 years ago
|
||
I was thinking actually of using NS_LITERAL_STRING at the caller.
But, actually, there's a better way. Remove the whole thing. GetTextNodeTag used to have a bunch of callsites -- places created things using that tag. Now there's only one callsite, and what it does is check it for equality. But nothing is created with it, so we can just remove the entire branch in CreateElementTxn.cpp that checks if (textNodeTag == mTag), and then remove GetTextNodeTag to boot.
|
|
Assignee | |
Comment 3•17 years ago
|
||
yes, this is much better
Attachment #269974 -
Attachment is obsolete: true
Attachment #270025 -
Flags: superreview?(dbaron)
Attachment #270025 -
Flags: review?(dbaron)
Attachment #269974 -
Flags: superreview?(dbaron)
Attachment #269974 -
Flags: review?(dbaron)
|
|
||
Comment 4•17 years ago
|
||
Comment on attachment 270025 [details] [diff] [review]
clean up more code
r+sr=dbaron
Attachment #270025 -
Flags: superreview?(dbaron)
Attachment #270025 -
Flags: superreview+
Attachment #270025 -
Flags: review?(dbaron)
Attachment #270025 -
Flags: review+
|
||
Comment 5•17 years ago
|
||
Does bug 386189 depend on this?
|
|
Assignee | |
Comment 6•17 years ago
|
||
|
|
Assignee | |
Updated•17 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•