Closed
Bug 386103
Opened 17 years ago
Closed 17 years ago
Localizability issues with search engine aliases
Categories
(Firefox :: Search, defect)
Firefox
Search
Tracking
()
VERIFIED
FIXED
Firefox 3 alpha6
People
(Reporter: marcoos, Assigned: rflint)
References
Details
Attachments
(1 file)
(deleted),
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
The duplicateTitle/duplicateBookmark properties aren't really localizable in their current form.
Copying&pasting to what I wrote in bug 378553:
(In reply to bug 378553 comment #10)
> >Index: components/search/content/engineManager.js
>
> >+ editKeyword: function engineManager_editKeyword() {
>
> >+ var dtitle = strings.getString("duplicateTitle");
> >+ var bookmark = strings.getString("duplicateBookmark");
> >+ var dmsg = strings.getFormattedString("duplicateMsg",
> >+ [(bduplicate) ? bookmark : '"' +
> >+ engine.name + '"']);
>
> We might end up having to change this to a fully localized string, if the hard
> coded quotes aren't suitable here for some locales, but we can cross that
> bridge when we come to it, I think.
Quotes are only part of the problem, not the most imporant one, though.
I really can't localize a sentence like this one into Polish. The word
"bookmark" is declensed differently than the word for "search engine" - which I
need to use as a prefix, so that I don't need to declense the (unknown!) name
of the search engine.
I mean, the Polish translation would be: "Wybrałeś słowo kluczowe używane
przez wyszukiwarkę %S", where "wyszukiwarkę" is the declensed word
"wyszukiwarka" = search engine.
This translated back into English would be:
"You have chosen a keyword that is currently in use by the %S search engine."
so we CAN'T really have %S evaluate to "a bookmark".
This should be split into two strings, like this:
duplicateMsgEngine=You have chosen a keyword that is currently in use by %S.
Please select another.
duplicateMsgBookmark=You have chosen a keyword that is currently in use by a
bookmark. Please select another.
reopening, ccing Pike.
Assignee | ||
Comment 1•17 years ago
|
||
Updated•17 years ago
|
Attachment #270068 -
Flags: review?(gavin.sharp) → review+
Updated•17 years ago
|
OS: Mac OS X → All
Hardware: PC → All
Target Milestone: --- → Firefox 3 alpha6
Assignee | ||
Comment 2•17 years ago
|
||
mozilla/browser/components/search/content/engineManager.js 1.16 mozilla/browser/locales/en-US/chrome/browser/engineManager.properties 1.2
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 3•17 years ago
|
||
verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X; pl; rv:1.9a6pre) Gecko/2007070204 Minefield/3.0a6pre
Status: RESOLVED → VERIFIED
Updated•17 years ago
|
Flags: in-testsuite-
You need to log in
before you can comment on or make changes to this bug.
Description
•