Closed Bug 386437 Opened 17 years ago Closed 10 years ago

Use inline tree editing instead of a modal dialog when changing keywords in the Search Engines Manager

Categories

(Firefox :: Search, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 34

People

(Reporter: ancestor.ak, Assigned: rflint)

References

Details

(Keywords: polish)

Right now when the user clicks the "Edit Keyword" button, a dialog pops up allowing to enter the keyword. Modal dialogs should be avoided when possible and there's certainly a better and more elegant alternative in this case. When the user clicks "Edit Keyword", the appropriate treecell should be focused and made editable, taking advantage of bug 201499.
My original implementation used editable treecells, but I switched over to the prompt due to accessibility concerns. Currently you can't invoke edit mode directly without a mouse (bug 350346) and they aren't read (by JAWS at least) when using a button to fiddle with startEditing(). I'll look into getting this to work properly.
Severity: normal → enhancement
Status: NEW → ASSIGNED
No longer depends on: 378553
Target Milestone: --- → Firefox 3
Assignee: nobody → ryan
Status: ASSIGNED → NEW
*sigh*
Status: NEW → ASSIGNED
Target Milestone: Firefox 3 → ---
Fixed by bug 1106559 (via bug 1106205).
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
You need to log in before you can comment on or make changes to this bug.