Closed Bug 386629 Opened 17 years ago Closed 17 years ago

toolbarbutton-1 icons has inconsistent behavior in hover:active state

Categories

(SeaMonkey :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.0a1

People

(Reporter: stefanh, Assigned: stefanh)

References

Details

Attachments

(2 files)

I was experimenting a bit with themes/classic/communicator/button.css, because I didn't want that "moving" (pressed) look on toolbarbuttons. But removing the appropiate style rules didn't stopped some icons from move (acting pressed). I also found some other inconsistent behaviour. I think the behaviour of the toolbarbuttons should be dependent on the *style* rules - atm it's impossible to have a consistent behaviour without the style rules in themes/classic/communicator/button.css: Those are the style rules: .toolbarbutton-1:hover:active, .toolbarbutton-1[open="true"], .toolbarbutton-1:hover:active > .toolbarbutton-menubutton-button { padding: 3px 2px 1px 3px; } . . . .button-toolbar:hover:active > .button-box { padding: 2px 1px 0px 3px; } (padding changes in hover:active state) 1) The "Get Msgs" and "Compose" buttons in MailNews moves when you press them. The other problem is in hover state: 2) The navigator "Stop" button and the print button looks like it moves in hover state. Note: this might have been an issue before the new icon set landed, but I'm making this bug block the themes bug anyway, since I think it should be sorted out during the new theme landing.
I don't think this is due to the icon set, it's more likely to be due to the switch to *stripe. For instance, at least on Windows, I also notice that we seem to have lost the hover/active feedback on the dropmarkers.
I'm pretty convinced that it is the icon set. If it was *stripe's fault you wouldn't have the effect on just some buttons.
Hmm, I should probably adjust the summary since we also have inconsistent behaviour because of *stripe. The issue I'm talking about can be seen clearly if you remove the style rules mentioned in comment #0. We use different icons in hover/hover:active states and it's this switch that causes the effect.
Summary: toolbarbuttons has inconsistent behavior in hover/hover:active state → toolbarbutton-1 icons has inconsistent behavior in hover/hover:active state
Attached patch Demo patch (deleted) — Splinter Review
Classic theme: Try this patch and hit the "Get Msgs" button in mailNews.
I suppose the image can be edited. Note: pretty ugly if you want to remove the button-down effect...
OK, so this should fix the "Get Msgs" button. The hover:active version was a bit more rightwards compared to the other ones - I just did a cut & paste ...
Attachment #290548 - Flags: superreview?(neil)
Attachment #290548 - Flags: review?(neil)
Adjusting summary, since I'll open a separate bug for the :hover state if necessary (and possible).
Summary: toolbarbutton-1 icons has inconsistent behavior in hover/hover:active state → toolbarbutton-1 icons has inconsistent behavior in hover:active state
Blocks: 406071
Attachment #290548 - Flags: superreview?(neil)
Attachment #290548 - Flags: superreview+
Attachment #290548 - Flags: review?(neil)
Attachment #290548 - Flags: review+
Checking in messengericons.png; /cvsroot/mozilla/suite/themes/classic/messenger/icons/messengericons.png,v <-- messengericons.png new revision: 1.2; previous revision: 1.1 done It appears that the "Compose" button was ok (must have been affected by something else), so I'm closing this one.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.0alpha
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee: general → stefanh
Status: REOPENED → NEW
(sorry, that was probably a bit too much)
Status: NEW → RESOLVED
Closed: 17 years ago17 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: