Closed
Bug 387015
Opened 17 years ago
Closed 17 years ago
The "Credits" button on Help -> About Dialog does not have an access key
Categories
(Firefox :: Keyboard Navigation, defect)
Firefox
Keyboard Navigation
Tracking
()
RESOLVED
FIXED
Firefox 3 alpha7
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
(Blocks 2 open bugs)
Details
(Keywords: access, Whiteboard: [in-litmus-bug-week])
Attachments
(1 file)
|
(deleted),
patch
|
asaf
:
review+
|
Details | Diff | Splinter Review |
We need an access key for the "Credits" button in order to make it easy to access via the keyboard. Since the button's label is toggled on activation, the access key should be valid in both states.
I'm posting a patch to fix this.
Attachment #271109 -
Flags: review?(mano)
|
||
Comment 1•17 years ago
|
||
Comment on attachment 271109 [details] [diff] [review]
The patch to add the access key handling both button title states
r=mano.
Attachment #271109 -
Flags: review?(mano) → review+
|
Assignee | |
Updated•17 years ago
|
Whiteboard: [checkin needed]
|
||
Updated•17 years ago
|
Keywords: checkin-needed
Whiteboard: [checkin needed]
|
||
Comment 2•17 years ago
|
||
browser/base/content/aboutDialog.js 1.8
browser/base/content/aboutDialog.xul 1.28
browser/locales/en-US/chrome/browser/aboutDialog.dtd 1.9
|
||
Updated•17 years ago
|
Flags: in-testsuite-
Litmus testcase added:
https://litmus.mozilla.org/show_test.cgi?id=12789
Flags: in-litmus? → in-litmus+
|
|
||
Comment 4•14 years ago
|
||
Anthony: we're removing the "Credits" button in bug 579547, so you'll have to revert that change :)
(In reply to comment #4)
> Anthony: we're removing the "Credits" button in bug 579547, so you'll have to
> revert that change :)
I'll do so when that bug is resolved. Thanks for the heads up.
You need to log in
before you can comment on or make changes to this bug.
Description
•