Dão Gottwald [:dao] Assignee
	Description • 17 years ago

The current class names (textbox-presentation-*) are neither very clear nor generic enough, given that the formatted URL stuff could become a separate binding for use outside of a textbox. I'd like to address this before others start adopting their themes.

The patch also fixes a bug in the stylesheets (.textbox-presentation-slash doesn't exist anymore).

	Dão Gottwald [:dao] Assignee
	Comment 1 • 17 years ago

(In reply to comment #0)
> The patch also fixes a bug in the stylesheets (.textbox-presentation-slash
> doesn't exist anymore).

Btw, this fix is needed to make hideProtocols work properly.

	:Gavin Sharp [email: gavin@gavinsharp.com]
	Comment 2 • 17 years ago

Comment on attachment 271183 [details] [diff] [review]
patch

>Index: browser/themes/qinstripe/browser/browser.css

>+#urlbar[chromedir="rtl"][protocolhidden="true"] .formatted-url-prePath > .formatted-url-subdomain ,
>+#urlbar[chromedir="ltr"][protocolhidden="true"] .formatted-url-prePath > .formatted-url-port 

Shouldn't these both be "rtl"?

This also made me realize that we don't support RTL in pinstripe, so we should probably file a bug on removing the rtl rules you added there. Or you can do it here if you want.

	Dão Gottwald [:dao] Assignee
	Comment 3 • 17 years ago

(In reply to comment #2)
> (From update of attachment 271183 [details] [diff] [review])
> >Index: browser/themes/qinstripe/browser/browser.css
> 
> >+#urlbar[chromedir="rtl"][protocolhidden="true"] .formatted-url-prePath > .formatted-url-subdomain ,
> >+#urlbar[chromedir="ltr"][protocolhidden="true"] .formatted-url-prePath > .formatted-url-port 
> 
> Shouldn't these both be "rtl"?

Nope, subdomain needs text-align:right for ltr / left for rtl, port needs text-align:left for ltr / right for rtl.

> This also made me realize that we don't support RTL in pinstripe, so we should
> probably file a bug on removing the rtl rules you added there. Or you can do it
> here if you want.

I didn't know that. I'll update the patch.

	Kenneth Herron
	Comment 5 • 17 years ago

Checked in "patch without RTL support for pinstripe". Clearing checkin-needed keyword.

	Dão Gottwald [:dao] Assignee
	Comment 6 • 17 years ago

thanks