Closed
Bug 387163
Opened 17 years ago
Closed 17 years ago
Build ID screwed up in trunk (hour appears twice)
Categories
(Toolkit Graveyard :: Build Config, defect)
Toolkit Graveyard
Build Config
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla1.9alpha8
People
(Reporter: cbook, Assigned: reed)
References
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
Current Build id for trunk is Build identifier: Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9a7pre) Gecko/200707060404 Minefield/3.0a7pre
it should be YYYYMMDDHH and is YYYYMMDDHHHH ?
Updated•17 years ago
|
Assignee: build → nobody
Component: Build & Release → General
Product: mozilla.org → Core
QA Contact: preed → general
Version: other → Trunk
Comment 1•17 years ago
|
||
For Mac:
Using about: in location bar:
Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a7pre) Gecko/200707060404 Minefield/3.0a7pre
In the About dialog:
Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a7pre) Gecko/2007070604 Minefield/3.0a7pre
This build started at 04:02.
Comment 2•17 years ago
|
||
Need to kill this code: http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/toolkit/content/about.xhtml&rev=1.23&mark=90-93#85.
However, it still begs the question of whether we want the "full" build ID in the UA string.
Comment 3•17 years ago
|
||
cc'ing some people who have had opinions before on how much of the build id to include in the UA string
Comment 4•17 years ago
|
||
(In reply to comment #2)
> Need to kill this code:
> http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/toolkit/content/about.xhtml&rev=1.23&mark=90-93#85.
We added it intentionally, so I don't see why we'd want to kill it. This bug was about the actual UA we send over the wire, I thought - if it's not, then I say it's INVALID.
Comment 5•17 years ago
|
||
My hack in about.xhtml assumes that the build id in the UA string is a shortened ID without the hour. My understanding is that currently, after bsmedberg's cleanup, the UA string now has the full 10-digit build id. Our options are thus:
* Change the UA string back and have it use a shortened build id, or
* Remove the code in about.xhtml so that it shows just the UA, which includes the full, correct build id
Currently, about.xhtml has a 12-digit franken-buildid, which is definitely not right.
Comment 6•17 years ago
|
||
Ah, I see. Sorry, my fault for skimming the bug too quickly. I still think there are two separate issues: 1) whether or not we want the over-the-wire UA to use the longer date, and whether that was an intentional change (what I thought this bug was), and 2) fixing about.xhtml to better deal with the longer build ID should we decide to keep it.
Comment 7•17 years ago
|
||
The UA should not suddenly start showing a longer build-id.
Comment 8•17 years ago
|
||
The change to the over-the-wire UA string were intentional, although I mean to file another bug to cover additional changes to the buildid which might include removing it from the UA string altogether.
Updated•17 years ago
|
Flags: blocking1.9?
Comment 9•17 years ago
|
||
Confirming with SeaMonkey:
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a6pre) Gecko/2007070201 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a7pre) Gecko/200707030505 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)
Assignee | ||
Comment 11•17 years ago
|
||
Revert zach's change to about.xhtml (bug 345993) so that the build id in about: shows the correct 10-digit build id.
Updated•17 years ago
|
Attachment #276342 -
Flags: review?(benjamin) → review+
Assignee | ||
Comment 12•17 years ago
|
||
Checking in about.xhtml;
/cvsroot/mozilla/toolkit/content/about.xhtml,v <-- about.xhtml
new revision: 1.24; previous revision: 1.23
done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Product: Core → Toolkit
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M8
Comment 13•17 years ago
|
||
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a8pre) Gecko/2007081402 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)
V.Fixed, with SeaMonkey.
Status: RESOLVED → VERIFIED
Flags: blocking1.9?
Comment 14•17 years ago
|
||
I filed bug 392204 for the issue mentioned in comment 7.
Updated•17 years ago
|
Summary: Build ID screwed up in trunk → Build ID screwed up in trunk (hour appears twice)
Updated•6 years ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•