Hussam Al-Tayeb Reporter
	Description • 17 years ago

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a7pre) Gecko/2007070709 Firefox/3.0a7pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a7pre) Gecko/2007070709 Firefox/3.0a7pre

bookmark subfolders don't collapse all the way when I click elsewhere.

Reproducible: Always

Steps to Reproduce:
Create a subfolder in your bookmarks called FOLDER1
Create another subfolder FOLDER2 and place it inside FOLDER1
Create another subfolder FOLDER3 and place it inside FOLDER2
Create another subfolder FOLDER4 and place it inside FOLDER3
Then expand FOLDER4
click anywhere in the page area in firefox
Actual Results:  
Only FOLDER4 and FOLDER3 collapse

Expected Results:  
All folders and bookmarks menu should collapse

This regressed sometime in the last 10 days.

	Peter van der Woude [:Peter6]
	Comment 1 • 17 years ago

You need to click on a page for the second time to collapse the full menu.

	Peter van der Woude [:Peter6]
	Comment 2 • 17 years ago

regressionrange:
Works is 20070704_0524_firefox-3.0a7pre.en-US.win32
fails in 20070704_0857_firefox-3.0a7pre.en-US.win32

http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1183551840&maxdate=1183564619

-> Bug 279703

	Neil Deakin Assignee
	Comment 3 • 17 years ago

This was caused because I changed the Detach method in a later iteration of the popups patch to clear the parent, so the item's parent was always null.

	Boris Zbarsky [:bzbarsky]
	Comment 4 • 17 years ago

Comment on attachment 271374 [details] [diff] [review]
get parent properly

Looks good.

	Al Billings [:abillings - ex-MoCo]
	Comment 5 • 17 years ago

Verified in Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a7pre) Gecko/200707110404 Minefield/3.0a7pre.

	Neil Deakin Assignee
	Comment 6 • 17 years ago

The test_closemenu_attribute.xul tests this as best as possible.