Open
Bug 387341
Opened 18 years ago
Updated 2 years ago
XPCOM timers should participate in cycle collection
Categories
(Core :: XPCOM, defect, P3)
Core
XPCOM
Tracking
()
NEW
People
(Reporter: brendan, Unassigned)
Details
See bug 383271. Please cite others bugs like it here, and add FIXME comments citing this bug to any JS cycle breaking that is unnecessary once this bug is fixed. I'll work on this for the next milestone.
/be
Comment 1•18 years ago
|
||
Explicit breaking of the cycle is common to almost all JS users of nsITimer. Some examples:
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/toolkit/mozapps/downloads/src/nsHelperAppDlg.js.in&rev=1.47&mark=513#507
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/browser/components/sessionstore/src/nsSessionStore.js&rev=1.64#248
Reporter | ||
Comment 2•18 years ago
|
||
Sure, of course -- I remember working with bryner like six years ago on one of those. So turn it around: how many bugs like bug 383271 might there be? Can we do some kind of grep for timer uses from JS that don't break?
/be
Comment 3•18 years ago
|
||
(In reply to comment #2)
> Can we do some kind of grep for timer uses from JS that don't break?
Most code I've seen uses timers directly. The only exception I know of, where JS is used to reduce duplication, is GAlarm.
Updated•17 years ago
|
Flags: blocking1.9?
Updated•17 years ago
|
Flags: blocking1.9? → blocking1.9+
Comment 4•17 years ago
|
||
Fixing bug 330128 might fix most of these issues.
Updated•17 years ago
|
Priority: -- → P3
Reporter | ||
Comment 5•17 years ago
|
||
Sayrer says we have mitigated otherwise. Disowning, hoping we redo XPCOM timers to use less noisy primitives than condvar-scheduled inter-thread communication.
/be
Assignee: brendan → nobody
Reporter | ||
Updated•17 years ago
|
Target Milestone: mozilla1.9alpha8 → ---
Updated•17 years ago
|
Flags: tracking1.9+ → wanted-next+
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•