Closed Bug 387646 Opened 18 years ago Closed 17 years ago

Endcap cleanup

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Platform:
x86
All
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 3 beta1

People

(Reporter: rflint, Assigned: rflint)

References

Details

(Keywords: perf)

Attachments

(2 files, 2 obsolete files)

Screenshot
(deleted), image/png
Details
Patch v1.1
(deleted), patch
mconnor
: review+
mconnor
: approval1.9+
Details | Diff | Splinter Review
Attached patch WIP (obsolete) (deleted) — — Splinter Review
The goal of this is to create a single endcap style, reduce the number of images and pare down on the amount of styling and structural elements needed.
Blocks: 378983
Target Milestone: Firefox 3 M7 → Firefox 3 M8
No longer blocks: 378983
Target Milestone: Firefox 3 M8 → Firefox 3 M9
Attached patch Patch (obsolete) (deleted) — — Splinter Review
Attachment #271798 - Attachment is obsolete: true
Attachment #280018 - Flags: review?(mconnor)
Attached image Screenshot (deleted) —
Shown with the patch from bug 24998 applied.
Attached patch Patch v1.1 (deleted) — — Splinter Review
Bah, forgot to remove the old images from jar.mn.
Attachment #280018 - Attachment is obsolete: true
Attachment #280030 - Flags: review?(mconnor)
Attachment #280018 - Flags: review?(mconnor)
Flags: blocking-firefox3?
OS: Windows XP → All
Flags: blocking-firefox3? → blocking-firefox3-
Whiteboard: [wanted-firefox3]
Comment on attachment 280030 [details] [diff] [review] Patch v1.1 r=me, but we should figure out how to kill the stack entirely as a next step
Attachment #280030 - Flags: review?(mconnor) → review+
Attachment #280030 - Flags: approval1.9?
Attachment #280030 - Flags: approval1.9? → approval1.9+
Checked in with temporary background images. Note that this will make the bottom corner of the button slightly fuzzy until bug 24998 lands. mozilla/browser/components/search/content/search.xml 1.99 mozilla/browser/base/content/browser.xul 1.372 mozilla/browser/themes/winstripe/browser/browser.css 1.94 mozilla/browser/themes/winstripe/browser/endcap-bkgnd-hover.png 1.3 mozilla/browser/themes/winstripe/browser/endcap-bkgnd.png 1.3 mozilla/browser/themes/winstripe/browser/jar.mn 1.52 mozilla/browser/themes/winstripe/browser/searchbar.css 1.18 mozilla/browser/themes/winstripe/browser/Go-bkgnd-rtl.png delete mozilla/browser/themes/winstripe/browser/Go-bkgnd.png delete mozilla/browser/themes/winstripe/browser/Go-mid-bottom-rtl.png delete mozilla/browser/themes/winstripe/browser/Go-mid-bottom.png delete mozilla/browser/themes/winstripe/browser/Go-mid-top-rtl.png delete mozilla/browser/themes/winstripe/browser/Go-mid-top.png delete mozilla/browser/themes/winstripe/browser/Search-bkgnd-rtl.png delete mozilla/browser/themes/winstripe/browser/Search-bkgnd.png delete mozilla/browser/themes/winstripe/browser/Search-mid-bottom-rtl.png delete mozilla/browser/themes/winstripe/browser/Search-mid-bottom.png delete mozilla/browser/themes/winstripe/browser/Search-mid-top-rtl.png delete mozilla/browser/themes/winstripe/browser/Search-mid-top.png delete
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Keywords: perf
Resolution: --- → FIXED
Blocks: 352678
How come the mid-bottom and mid-top images were removed? Weren't they supposed to create a separator between the star and go button? (Not that it worked before this checkin anyways)
Depends on: 396274
(In reply to comment #7) > Weren't they supposed to create a separator between the star and go button? (Not > that it worked before this checkin anyways) > No, they were horizontal elements that were repeated to allow the button to scale vertically while keeping the background intact.
Depends on: 398020
Flags: wanted-firefox3+
Whiteboard: [wanted-firefox3]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: