These fields are pretty easy to set and check.

This will probably have a small conflict by the time you get to reviewing it, but it's easy to fix.

Okay, here. Fixed the bitrot.

Comment on attachment 272190 [details] [diff] [review] v1.1 >- if ($bug->check_can_change_field($field, 0, 1, \$PrivilegesRequired)) { Here, if a user cannot change these fields, they are ignored. With your patch, these fields are always taken into account, but if the user is not allowed to edit them, the checkboxes are disabled, and now $bug->foo_accessible think the user tried to clear the checkbox and throw an error.

Okay. I decided the simplest way to fix that was to keep a check_can_change inside of process_bug. check_can_change is really fast, so there's no reason not to call it again. This way, when we implement the webservice updaters for these fields, set_ will still throw errors if you try to change them when you can't.

Comment on attachment 272307 [details] [diff] [review] v2 In user-error.html.tmpl, for "illegal_change", write [% IF oldvalue.defined %] and [% IF newvalue.defined %]. .defined is missing and so when foo_accessible is 0, the corresponding part of the error message is hidden. r=LpSolit

Checking in process_bug.cgi; /cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v <-- process_bug.cgi new revision: 1.378; previous revision: 1.377 done Checking in Bugzilla/Bug.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v <-- Bug.pm new revision: 1.192; previous revision: 1.191 done Checking in Bugzilla/Object.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Object.pm,v <-- Object.pm new revision: 1.17; previous revision: 1.16 done Checking in template/en/default/global/user-error.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl,v <-- user-error.html.tmpl new revision: 1.217; previous revision: 1.216 done