For the recently used tags query, we need support for something like place:folder=[TAG_ROOT]&sort=[LAST_MODIFIED]&maxResults=10 tags are folders (under the tag root, for example, folder=3), and a tagged uri is a bookmark under that folder. we want support for a query that results in the child folders of a folder, sorted by last modified.

mano, some questions: 1) do you want the results of this sort of query to be nsNavHistoryFolderResultNodes? 2) Do you want the results to only be the folders, or do you want the the sort and max results to apply to the tags (bookmarks), and potential sub folders of those folders in those folders? based on the mockup in http://wiki.mozilla.org/Places:User_Interface/I6, I think you want nsNavHistoryFolderResultNodes, the max results to apply only to the top level. I have a modest patch in my tree that adds QUERY_TYPE_FOLDERS (2) as a query type (making QUERY_TYPE_UNIFIED=3, which we still don't support yet) In nsNavHistoryFolderResultNode::FillChildren(), after we sort, I remove children from the end of the array until we have maxResults. note, the tags (bookmarks) in these folders are currently recursively sorted by the same sort, but the max result value is ignored. place:folder=4&queryType=2&sort=14&maxResults=5 will this work for you?

Comment on attachment 272731 [details] [diff] [review] patch, v1 > will this work for you? seeing if this will work for Mano by seeking a review.

Comment on attachment 273267 [details] [diff] [review] updated (bit rot) not the complete patch

<Mano> in particular, how does this deal with live update? <Mano> also, tags are folders, not bookmarks <Mano> so we need to search for just that <Mano> we should use a complex query here imo.

> not the complete patch in addition to not being complete, it doesn't work at all, and I don't see how it ever did what I thought it did.

Thinking about this more, I will use (and thus re-enable) the remote containers implementation for the tags queries, then we don't need to abuse the query API that much. Please WONTFIX, unless you need this for something other than the tags-smart-folders.

WONTFIX, per Asaf's comment #8

Can Asaf or someone else clarify what this WONTFIX actually means? From what I understand from comment #8, searching for folders will be implemented in a different manner than discussed in this bug, and not that it won't be implemented at all, right?

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h". In Thunderbird 3.0b, you do that as follows: Tools | Message Filters Make sure the correct account is selected. Click "New" Conditions: Body contains places-to-b-and-h Change the action to "Delete Message". Select "Manually Run" from the dropdown at the top. Click OK. Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter. Gerv