Closed
Bug 388504
Opened 17 years ago
Closed 17 years ago
It should be possible for an extension to reload Page Info on a different document
Categories
(Firefox :: Page Info Window, defect)
Firefox
Page Info Window
Tracking
()
RESOLVED
FIXED
Firefox 3 alpha8
People
(Reporter: florian, Assigned: florian)
References
Details
Attachments
(1 file)
(deleted),
patch
|
db48x
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
An extension should be able to reload the content of Page Info for a different document.
With this patch, an extension can set new values for gDocument and gWindow and then call the resetPageInfo function.
This feature can't be implemented entirely in the extension that uses it because other extensions will need to provide a function to clear the information they display before the new information is loaded. The patch adds a new hook (onResetRegistry) for that purpose.
Attachment #272703 -
Flags: review?(mano)
Comment 1•17 years ago
|
||
Comment on attachment 272703 [details] [diff] [review]
patch v1
r=db48x
Attachment #272703 -
Flags: review?(mano) → review+
Assignee | ||
Updated•17 years ago
|
Attachment #272703 -
Flags: superreview?(neil)
Comment 2•17 years ago
|
||
Comment on attachment 272703 [details] [diff] [review]
patch v1
>+ /* Select the requested tab, if the name is specified */
>+ var initialTab = "general";
>+ if ("arguments" in window && window.arguments.length >= 1 &&
>+ window.arguments[0] && window.arguments[0].initialTab)
>+ initialTab = window.arguments[0].initialTab;
>+ var radioGroup = document.getElementById("viewGroup");
>+ initialTab = document.getElementById(initialTab + "Tab") || document.getElementById("generalTab");
>+ radioGroup.selectedItem = initialTab;
There is actually an alternative way of doing this. If you set value attributes on all the radiobuttons then you can do radioGroup.value = initialTab; and it will select the radiobutton with the matching value.
Attachment #272703 -
Flags: superreview?(neil) → superreview+
Assignee | ||
Updated•17 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 M8
You need to log in
before you can comment on or make changes to this bug.
Description
•