note that reports.cgi has several output modes, so this needs to be fixed for all modes.

moving to real milestones...

-> myk, cuz I have a patch for this

My biggest problem w/this patch is that if the product is defined, you don't get the header (because of line 80). Also, the footers are suppressed. I realize that this is mostly by design (the $FORM{'banner'} variable), but I think that error messages could ignore that flag. Of course, in theory, these messages should never be seen ;)

The patch I just attached reorganizes the code in reports.cgi so headers and footers display correctly on errors and removes some crufty error checking code that is no longer necessary. I added a function to CGI.pl called "DisplayError" that uses the "errorhtml" parameter to display validation errors. It works a lot like PuntTryAgain but it prints HTTP response and HTML headers, and it doesn't stop execution after it prints the message in order to make the calling code easier to understand, since: DisplayError("blah") && exit; is a lot more descriptive than: DisplayError("blah");

Code looks good... I ran a few simple reports (on my 7 bugs ;) and everything worked. Tested passing the param mentioned in the URL and got the error... r=jake

Checked in.

Moving to Bugzilla product