errors when I attempt to add a new folder with a description (new folder dialog doesn't dismiss) steps to reproduce: 1) right click on the personal toolbar, do "new folder" 2) for the new folder, add a description "foo" 3) hit "add" expected results: folder added with description "foo" actual results: folder added, but no description and the "add folder" dialog does not dismiss. from my console: WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(rv)) failed: file c:/builds/trunk/mozilla/t oolkit/components/places/src/nsAnnotationService.cpp, line 308 WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(rv)) failed: file c:/builds/trunk/mozilla/t oolkit/components/places/src/nsAnnotationService.cpp, line 504 WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(rv)) failed: file c:/builds/trunk/mozilla/t oolkit/components/places/src/nsAnnotationService.cpp, line 463 ************************************************************ * Call to xpconnect wrapped JSObject produced this error: * [Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VAL UE) [nsIAnnotationService.setItemAnnotation]" nsresult: "0x80070057 (NS_ERROR_I LLEGAL_VALUE)" location: "JS frame :: chrome://browser/content/places/utils.js :: anonymous :: line 1380" data: no] ************************************************************ ************************************************************ * Call to xpconnect wrapped JSObject produced this error: * [Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VAL UE) [nsIAnnotationService.setItemAnnotation]" nsresult: "0x80070057 (NS_ERROR_I LLEGAL_VALUE)" location: "JS frame :: chrome://browser/content/places/utils.js :: anonymous :: line 1380" data: no] ************************************************************

investigating

1) this.id should be this._id 2) improve test of places transaction manager so that it will fail without this fix

Comment on attachment 274324 [details] [diff] [review] patch thanks seth, r=me

fixed. this has a=mconnor for A7 (over email). Checking in src/nsPlacesTransactionsService.js; /cvsroot/mozilla/browser/components/places/src/nsPlacesTransactionsService.js,v <-- nsPlacesTransactionsService.js new revision: 1.4; previous revision: 1.3 done Checking in tests/unit/test_placesTxn.js; /cvsroot/mozilla/browser/components/places/tests/unit/test_placesTxn.js,v <-- test_placesTxn.js new revision: 1.6; previous revision: 1.5 done

verified with: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre) Gecko/2007073005 Minefield/3.0a7pre

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h". In Thunderbird 3.0b, you do that as follows: Tools | Message Filters Make sure the correct account is selected. Click "New" Conditions: Body contains places-to-b-and-h Change the action to "Delete Message". Select "Manually Run" from the dropdown at the top. Click OK. Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter. Gerv