I'm now getting this build error. I think a regression of bug atrix.o gfxPath.o gfxPattern.o gfxPlatform.o gfxRect.o gfxSkipChars.o gfxTextRun Cache.o gfxTextRunWordCache.o gfxWindowsFonts.o gfxWindowsPlatform.o gfxWindowsS urface.o gfxWindowsNativeDrawing.o nsUnicodeRange.o gfxPDFSurface.o ./module.r es -L../../../gfx/cairo/cairo/src -lmozcairo -L../../../gfx/cairo/libpi xman/src -lmozlibpixman ../../../dist/lib/libunicharutil_s.a -L../../../dist/li b -lxpcom -lxpcom_core -L../../../dist/lib -lnspr4 -lplc4 -lplds4 -L../../../mod ules/zlib/src -lmozz ../../../dist/lib/mozlcms.lib -lm -lgdi32 -lwinmm -lwsoc k32 -lusp10 -luuid g++.exe: ../../../dist/lib/mozlcms.lib: No such file or directory make[6]: *** [thebes.dll] Error 1 make[6]: Leaving directory `/cygdrive/c/mozilla/mozilla/gfx/thebes/src' make[5]: *** [libs] Error 2 make[5]: Leaving directory `/cygdrive/c/mozilla/mozilla/gfx/thebes' make[4]: *** [libs] Error 2 make[4]: Leaving directory `/cygdrive/c/mozilla/mozilla/gfx' make[3]: *** [libs_tier_gecko] Error 2 make[3]: Leaving directory `/cygdrive/c/mozilla/mozilla' make[2]: *** [tier_gecko] Error 2 make[2]: Leaving directory `/cygdrive/c/mozilla/mozilla' make[1]: *** [alldep] Error 2 make[1]: Leaving directory `/cygdrive/c/mozilla/mozilla' make: *** [alldep] Error 2

If you change configure.in from testing: if test "$OS_ARCH" = "WINNT"; then to testing: if test "$_WIN32_MSVC"; then like the cairo code just above it does, does that fix it? (You have to rebuild configure using autoconf 2.1x.)

Well, I could try that. Atm, I'm trying to get a working build by checking out prior to the patch that caused, but I got another build error instead. I've filed bug 389411 for that.

Thanks, that seems to work. I haven't got a successful build yet, but the issues I get in bug 389411 happen later in the build process, I think.

Comment on attachment 273781 [details] [diff] [review] patch r=dbaron

Comment on attachment 273781 [details] [diff] [review] patch I'm a little surprised that this works in a dynamic (non-libxul) build. Did you try it?

Well, I tried it in a debug build with these options: ac_add_options --enable-debug ac_add_options --disable-libxul So I think I've tried this in a non-libxul build.

Comment on attachment 273781 [details] [diff] [review] patch Ugh, I forgot about this one.

Comment on attachment 273781 [details] [diff] [review] patch a=bzbarky

Checking in configure.in; /cvsroot/mozilla/configure.in,v <-- configure.in new revision: 1.1863; previous revision: 1.1862 done Checked in. Thanks for the approval!