Closed
Bug 389675
Opened 17 years ago
Closed 17 years ago
[SeaMonkey port] Tab drag and drop indicator (arrow) only works after first drag of a tab
Categories
(SeaMonkey :: General, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
seamonkey2.0a1
People
(Reporter: sgautherie, Assigned: neil)
References
(Blocks 1 open bug)
Details
(Keywords: regression)
Attachments
(1 file)
|
(deleted),
patch
|
jag+mozilla
:
review+
jag+mozilla
:
superreview+
|
Details | Diff | Splinter Review |
See bug 338302 comment 54...
{{{
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a7pre)
Gecko/200707251717 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)
Bug still there, in SeaMonkey.
I wonder if the following file(s) should be fixed too ?
{{
/themes/classic/navigator/mac/tabbrowser.css,
* line 92 -- .tab-drop-indicator-bar {
/themes/classic/navigator/win/tabbrowser.css,
* line 54 -- .tab-drop-indicator-bar {
/themes/modern/navigator/tabbrowser.css,
* line 108 -- .tab-drop-indicator-bar {
}}
}}}
|
Assignee | |
Comment 1•17 years ago
|
||
Since we intelligently put the half-indicator-width measurement in the skin where it belongs we can simply switch from hidden to collapsed.
|
||
Comment 2•17 years ago
|
||
Comment on attachment 275244 [details] [diff] [review]
Proposed patch
r/sr=jag though I still wonder what changed. This stuff used to work just fine. Why does an async load of the mouse cursor image not go through until the drag is done?
Attachment #275244 -
Flags: superreview+
Attachment #275244 -
Flags: review?(cst)
Attachment #275244 -
Flags: review+
|
||
Comment 3•17 years ago
|
||
(In reply to comment #2)
> (From update of attachment 275244 [details] [diff] [review])
> r/sr=jag though I still wonder what changed.
Bug 338302 comment 2 says "nsIThreadManager".
|
|
Assignee | |
Comment 4•17 years ago
|
||
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
Reporter | |
Comment 5•17 years ago
|
||
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a9pre) Gecko/2007092402 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a9pre) Gecko/2007092502 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)
V.Fixed between these two nighlies.
Status: RESOLVED → VERIFIED
|
||
Updated•17 years ago
|
Target Milestone: --- → seamonkey2.0alpha
|
|
Reporter | |
Comment 6•17 years ago
|
||
Should this patch be backed out, now that bug 389931 (which fixed bug 326273 regression) is fixed ?
Blocks: nsIThreadManager
|
|
Assignee | |
Comment 7•17 years ago
|
||
(In reply to comment #6)
>Should this patch be backed out, now that bug 389931 is fixed ?
We could do, I guess... jag, any thoughts?
|
|
||
Comment 8•17 years ago
|
||
Unless there's a good reason to use hidden instead of collapsed, let's spend our energy elsewhere.
You need to log in
before you can comment on or make changes to this bug.
Description
•