Closed
Bug 389697
Opened 17 years ago
Closed 17 years ago
remove freetype2 font code
Categories
(Core Graveyard :: GFX, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dbaron, Assigned: dbaron)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
vlad
:
review+
vlad
:
approval1.9+
|
Details | Diff | Splinter Review |
I have a patch to remove some additional code that's no longer used now that cairo is the only option. This is the freetype2 font code, which allowed Mozilla to find fonts using freetype2 (if the user configured Mozilla to tell it where to look, which meant it wasn't particularly useful).
This patch also some default values for preferences that were used by that code, and some preferences that were used by other pre-Xft X11 font code.
Note that we still need the configure check for the freetype2 library since cairo needs it.
Attachment #273998 -
Flags: review?(vladimir)
Assignee | ||
Comment 1•17 years ago
|
||
Er, which allowed Mozilla to display fonts using freetype2 (if the user configured Mozilla to tell it where to find the fonts, which meant it wasn't particularly useful).
Comment 2•17 years ago
|
||
FYI, I think there are few more places that should be fixed:
http://lxr.mozilla.org/seamonkey/search?string=MOZ_ENABLE_FREETYPE2
Assignee | ||
Comment 3•17 years ago
|
||
This addresses Mats's comments (removes the 2 files in gfx/idl and the line in autoconf.mk.in).
I think we can probably also remove nsFontList/nsIFontList (although I'm not sure), but that would be a pretty sizable patch, so should be separate.
Attachment #273998 -
Attachment is obsolete: true
Attachment #282189 -
Flags: review?(vladimir)
Attachment #273998 -
Flags: review?(vladimir)
Assignee | ||
Comment 4•17 years ago
|
||
Oops, I forgot to exclude the configure diffs from the new patch, so it's much bigger than it needs to be...
Attachment #282189 -
Flags: review?(vladimir) → review+
Attachment #282189 -
Flags: approval1.9+
Assignee | ||
Comment 5•17 years ago
|
||
And another followup should be removing MOZ_ENABLE_XFT, I think...
Assignee | ||
Comment 6•17 years ago
|
||
Checked in to trunk.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 7•17 years ago
|
||
Filed bug 397813 on nsFontList/nsIFontList.
Updated•16 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•