Closed
Bug 389735
Opened 17 years ago
Closed 16 years ago
Unable to open a message in a tab when using the vertical layout
Categories
(Thunderbird :: Mail Window Front End, defect, P2)
Thunderbird
Mail Window Front End
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0b1
People
(Reporter: mscott, Assigned: philor)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
Current trunk nightly. I think I may have mentioned this before in the tab bug.
If you use the vertical view, and you open a message in a tab, the tab is messed up. We aren't collapsing the right elements.
|
||
Updated•17 years ago
|
OS: Windows Vista → All
Hardware: PC → All
|
||
Updated•17 years ago
|
Version: 2.0 → Trunk
|
Assignee | |
Comment 1•16 years ago
|
||
Forgot all about this, until I switched to using vertical, and thought we'd newly broken something.
Assignee: nobody → philringnalda
Status: NEW → ASSIGNED
Attachment #344832 -
Flags: review?(mkmelin+mozilla)
|
|
Assignee | |
Updated•16 years ago
|
|
|
||
Comment 2•16 years ago
|
||
Comment on attachment 344832 [details] [diff] [review]
Fix v.1
>+ if (layout == kVerticalPaneConfig)
>+ {
>+ document.getElementById("threadTree").collapsed = collapse;
>+ } else {
>+ document.getElementById("displayDeck").collapsed = collapse;
>+ }
Nit: no need for the braces. r=mkmelin
Attachment #344832 -
Flags: review?(mkmelin+mozilla) → review+
|
|
Assignee | |
Comment 3•16 years ago
|
||
http://hg.mozilla.org/comm-central/rev/5483391f6d47
I really wanted to blame those braces on style-of-the-file, but I had to page up three times to get to another set, so that's going to be a tough sell.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b1
You need to log in
before you can comment on or make changes to this bug.
Description
•