David Baron :dbaron: Reporter
	Description • 17 years ago

I'm seeing 

###!!! ASSERTION: I don't know what scope to use!: 'Error', file /builds/trunk/mozilla/dom/src/base/nsDOMClassInfo.cpp, line 5989

probably related to HTTP auth dialogs that come up when restoring my Firefox session.  (I have a saved session that includes 4 pages that bring up HTTP auth dialogs, and they all pop up when I restore.)  Note that I got 5 assertions.

	Blake Kaplan (:mrbkap) (inactive) Assignee
	Comment 2 • 17 years ago

I must have been getting lazy... The assertion is harmless, I believe in the cases that we should have been hitting it. With this patch I was able to go to a site requiring HTTP authentication, and did not get any assertions.

	Justin Dolske [:Dolske]
	Comment 3 • 17 years ago

I don't get any assertions (without the patch) on OS X or Linux. I suspect whatever dbaron was seeing may have been unique to startup or session restore?

	Johnny Stenback (:jst)
	Comment 4 • 17 years ago

Comment on attachment 274125 [details] [diff] [review]
Proposed fix

+        } else if (!(innerWin = oldWin->GetCurrentInnerWindowInternal())) {
+          scope = innerWin->GetGlobalJSObject();

This is in the code you're moving too (and I didn't see this the first time I reviewed it), but this aint right, if we ever get in here innerWin will be null.

r-

	Johnny Stenback (:jst)
	Comment 6 • 17 years ago

Comment on attachment 274207 [details] [diff] [review]
Oops, sorry

r+sr=jst

	Blake Kaplan (:mrbkap) (inactive) Assignee
	Comment 7 • 17 years ago

Fix checked into trunk.