To ensure the security of updates (and chrome triggered installs) xpinstall should drop xpis that come from invalid ssl sites. This should happen on the install-from-chrome and install-with-hashes entry points. Installs from web clicks should still quiz the user about invalid certificates.

This is a straight port of http://mxr.mozilla.org/seamonkey/source/toolkit/mozapps/shared/src/badCertHandler.js except that we only do the certificate checks if the request came from chrome. In the event that a chrome initiated download comes from an invalid certificate, the download fails with error -228.

The patch requires the minor fix from bug 390143

Comment on attachment 274596 [details] [diff] [review] patch rev 1 Looks good, r=dveditz

Comment on attachment 274596 [details] [diff] [review] patch rev 1 This is required for the work in bug 378216 which is blocking-firefox3

Comment on attachment 274596 [details] [diff] [review] patch rev 1 a=bzbarsky

Checking in xpinstall/src/Makefile.in; /cvsroot/mozilla/xpinstall/src/Makefile.in,v <-- Makefile.in new revision: 1.98; previous revision: 1.97 done Checking in xpinstall/src/nsXPInstallManager.cpp; /cvsroot/mozilla/xpinstall/src/nsXPInstallManager.cpp,v <-- nsXPInstallManager.cpp new revision: 1.150; previous revision: 1.149 done Checking in xpinstall/src/nsXPInstallManager.h; /cvsroot/mozilla/xpinstall/src/nsXPInstallManager.h,v <-- nsXPInstallManager.h new revision: 1.42; previous revision: 1.41 done