Jeff Walden [:Waldo] Assignee
	Description • 17 years ago

Bug 389988 made showModalDialog return null in any case where opening the window failed: blocked by popup blocker, security errors, OOM, etc.  This seems like a good idea for m7 so that content authors can get used to null being returned if the window open is blocked, just as occurs with window.open and the popup blocker.

However, going forward bz thinks it makes sense to make showModalDialog throw in some cases -- security errors certainly, OOM probably, and maybe other things.  (bz, please do correct this list if I didn't understand you correctly.)  We should determine the exact set of situations where we want showModalDialog to throw, and we should make it do so in those cases.

	Boris Zbarsky [:bzbarsky]
	Comment 1 • 17 years ago

I think showModalDialog should throw exactly when window.open throws, basically.  I still think passing in true for the js fixups arg should be considered as the simplest way to accomplish this.

	Johnny Stenback (:jst)
	Comment 2 • 17 years ago

We should make Firefox behave like IE does here.

	Jonas Sicking (:sicking) No longer reading bugmail consistently
	Comment 3 • 17 years ago

bz, would passing PR_TRUE there just fix this? Jeff, you wanna try and write up a patch?

	Boris Zbarsky [:bzbarsky]
	Comment 4 • 17 years ago

> bz, would passing PR_TRUE there just fix this? 

I don't know.  What does IE do?  See comment 2.

Passing PR_TRUE would make it behave like window.open, yes.

	Jeff Walden [:Waldo] Assignee
	Comment 5 • 17 years ago

I believe I looked into this several weeks ago and found out that was the right fix, but I don't really trust my memory right now, so I need to double-check that before finishing this up.

	Nochum Sossonko [:Natch]
	Comment 6 • 14 years ago

Is this behavior still desired?

	Firefox Bug Husbandry Bot
	Comment 7 • 6 years ago

Bulk priority change, per :mdaly

	Masatoshi Kimura [:emk]
	Comment 8 • 6 years ago

We removed showModalDialog.