It would be useful for logging purposes to let nsIXPConnect::debugDumpJSStack take a FILE*, so that we could dump the JS stack to files instead of just to stdout. Looking at my stack dumps with lots of xul!nsXPCWrappedJSClass::CallMethod isn't that useful for me, unfortunately. (This is for logging, so breaking into the debugger doesn't help - in my case there's appx. 70k stacks, because I don't really know what I'm looking for yet!)

Comment on attachment 274810 [details] [diff] [review] something like this #include <stdio.h> please. And document in the various places that the FILE* can be null and that this stdout?

I'm not quite sure where to put the comments (since this was mostly undocumented), so re-asking for sr? to make sure this is okay. Carrying over r+.

Comment on attachment 274971 [details] [diff] [review] add comments, use <stdio.h> I would *much* prefer that this take a fd rather than a FILE*. FILE* cannot be passed across CRT boundaries.

Use fd instead of FILE*; adds dependency on <io.h> instead, and removes the added comments (because there's no default - fd 0 is stdin; I have no idea how you can possibly write to it, but it's still a valid fd)

Comment on attachment 275048 [details] [diff] [review] use fd instead of FILE* >Index: js/src/xpconnect/src/nsXPConnect.cpp >+nsXPConnect::DebugDumpJSStack(int filedesc, >- printf("failed to get nsIThreadJSContextStack service!\n"); >+ _write(filedesc, "failed to get nsIThreadJSContextStack service!\n", 47); Magic numbers are bad. Can we avoid them using the following paradigm: static const char kFailed[] = "failed to get nsIThreadJSContextStack service!\n"; _write(filedesc, kFailed, sizeof(kFailed)-1);

Comment on attachment 275717 [details] [diff] [review] use static const char[] sr=bzbarsky, but bonus points for NS_ARRAY_LENGTH(foo) instead of |sizeof(foo) - 1|

NS_ARRAY_LENGTH(foo) will still count the null-termination... you would have to have NS_ARRAY_LENGTH(foo) - 1, which IMO is uglier than sizeof(foo) - 1

Checking in js/src/xpconnect/idl/nsIXPConnect.idl; /cvsroot/mozilla/js/src/xpconnect/idl/nsIXPConnect.idl,v <-- nsIXPConnect.idl new revision: 1.56; previous revision: 1.55 done Checking in js/src/xpconnect/src/nsXPConnect.cpp; /cvsroot/mozilla/js/src/xpconnect/src/nsXPConnect.cpp,v <-- nsXPConnect.cpp new revision: 1.131; previous revision: 1.130 done Checking in js/src/xpconnect/src/xpcdebug.cpp; /cvsroot/mozilla/js/src/xpconnect/src/xpcdebug.cpp,v <-- xpcdebug.cpp new revision: 1.18; previous revision: 1.17 done Checking in js/src/xpconnect/src/xpcprivate.h; /cvsroot/mozilla/js/src/xpconnect/src/xpcprivate.h,v <-- xpcprivate.h new revision: 1.232; previous revision: 1.231 done Checking in js/src/xpconnect/src/xpcwrappednative.cpp; /cvsroot/mozilla/js/src/xpconnect/src/xpcwrappednative.cpp,v <-- xpcwrappednative.cpp new revision: 1.153; previous revision: 1.152 done

I backed this out due to compile errors. ../../../../dist/include/system_wrappers/io.h:3:21: error: io.h: No such file or directory Looks pretty easy to fix, but I needed to run, so backing out was the easiest. :)

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.