RLk stats jumped from 4.92 KB to 8.55 KB from IRC: <dietrich> mozStorageStatement 1296 1250.00% <dietrich> nsVoidArray 136 325.00% <dietrich> nsStringBuffer 1264 203.85% <dietrich> mozStorageConnection 128 100.00% <dietrich> nsStandardURL 704 100.00% <dietrich> nsTArray_base 12 50.00% <dietrich> nsLocalFile 336 50.00% <dietrich> nsWeakReference 128 33.33% http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1186086420.10822.gz&fulltext=1 it appears to be from bug #382877 - dynamic containers implementation, part 1. I'll investigate

fxdbug-linux-tbox also showed leak increases from: RLk:36.0B Lk:1.24MB to: RLk:3.90KB Lk:1.49MB

From the patch in 382877: + + this._bms.addObserver(this, false); +

Checking in toolkit/components/places/src/nsNavBookmarks.cpp; /cvsroot/mozilla/toolkit/components/places/src/nsNavBookmarks.cpp,v <-- nsNavBookmarks.cpp new revision: 1.117; previous revision: 1.116 done

(In reply to comment #4) > Checking in toolkit/components/places/src/nsNavBookmarks.cpp; > /cvsroot/mozilla/toolkit/components/places/src/nsNavBookmarks.cpp,v <-- > nsNavBookmarks.cpp > new revision: 1.117; previous revision: 1.116 > done > Heh, looks like my suggestion caused leaks. sorry about that!

This looks like it fixed leaks on Linux and caused leaks on Mac.

(In reply to comment #5) > (In reply to comment #4) > > Checking in toolkit/components/places/src/nsNavBookmarks.cpp; > > /cvsroot/mozilla/toolkit/components/places/src/nsNavBookmarks.cpp,v <-- > > nsNavBookmarks.cpp > > new revision: 1.117; previous revision: 1.116 > > done > > > > Heh, looks like my suggestion caused leaks. sorry about that! > backed out

Comment on attachment 275057 [details] [diff] [review] redux r=mano

Checking in toolkit/components/places/src/nsLivemarkService.js; /cvsroot/mozilla/toolkit/components/places/src/nsLivemarkService.js,v <-- nsLivemarkService.js new revision: 1.21; previous revision: 1.20 done

leaks back to previous level.

yep, still at 4.93

OK, this solves this specific leak, but maybe we should add cycle collection to the annotation service and the bookmark service. Do we use these elsewhere? I suspect extensions are likely to, even if we don't.

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h". In Thunderbird 3.0b, you do that as follows: Tools | Message Filters Make sure the correct account is selected. Click "New" Conditions: Body contains places-to-b-and-h Change the action to "Delete Message". Select "Manually Run" from the dropdown at the top. Click OK. Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter. Gerv