Closed
Bug 390712
Opened 17 years ago
Closed 17 years ago
reloading a live bookmark generates warnings
Categories
(Firefox :: Bookmarks & History, defect)
Tracking
()
VERIFIED
FIXED
Firefox 3 alpha8
People
(Reporter: Peter6, Assigned: asaf)
References
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
patch
|
dietrich
:
review+
|
Details | Diff | Splinter Review |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre) Gecko/2007080213 Minefield/3.0a7pre ID:2007080213
repro:
Go to bookmarks toolbar, a live bookmark, rightclick and choose reload.
result:
Warning: reference to undefined property Ci.nsINavHistoryResultNode.RESULT_TYPE_REMOTE_CONTAINER
Source file: chrome://browser/content/places/controller.js
Line: 486
Warning: reference to undefined property asContainer(node).remoteContainerType
Source file: chrome://browser/content/places/controller.js
Line: 494
Reporter | ||
Comment 1•17 years ago
|
||
regressionwindow:
works in 20070802_1221_firefox-3.0a7pre.en-US.win32
fails in 20070802_1330_firefox-3.0a7pre.en-US.win32
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=1186085580&maxdate=1186086599&cvsroot=%2Fcvsroot
->Bug 382877
Blocks: 382877
Assignee | ||
Comment 2•17 years ago
|
||
Comment 3•17 years ago
|
||
Comment on attachment 275032 [details] [diff] [review]
patch
>Index: browser/components/places/content/controller.js
>===================================================================
>RCS file: /cvsroot/mozilla/browser/components/places/content/controller.js,v
>retrieving revision 1.171
>diff -u -p -8 -r1.171 controller.js
>--- browser/components/places/content/controller.js 18 Jul 2007 21:39:23 -0000 1.171
>+++ browser/components/places/content/controller.js 2 Aug 2007 22:31:49 -0000
>@@ -456,17 +456,17 @@ PlacesController.prototype = {
>
> /**
> * Gathers information about the selected nodes according to the following
> * rules:
> * "link" node is a URI
> * "bookmark" node is a bookamrk
> * "folder" node is a folder
> * "query" node is a query
>- * "remotecontainer" node is a remote container
>+ * "dynamiccontainer" node is a dynamic container
nit: line up "node"
>@@ -492,26 +492,22 @@ PlacesController.prototype = {
> var uri = null;
>
> // We don't use the nodeIs* methods here to avoid going through the type
> // property way too often
> switch(nodeType) {
> case Ci.nsINavHistoryResultNode.RESULT_TYPE_QUERY:
> nodeData["query"] = true;
> break;
>- case Ci.nsINavHistoryResultNode.RESULT_TYPE_REMOTE_CONTAINER:
>- nodeData["remotecontainer"] = true;
>+ case Ci.nsINavHistoryResultNode.RESULT_TYPE_DYNAMIC_CONTAINER:
>+ nodeData["dynamiccontainer"] = true;
are the consumers of this updated already?
Attachment #275032 -
Flags: review?(dietrich) → review+
Assignee | ||
Comment 4•17 years ago
|
||
there are no in-tree consumers.
mozilla/browser/components/places/content/controller.js 1.172
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•17 years ago
|
Target Milestone: --- → Firefox 3 M8
Reporter | ||
Comment 5•17 years ago
|
||
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a7pre) Gecko/2007080223 Minefield/3.0a7pre ID:2007080223
VERIFIED
Status: RESOLVED → VERIFIED
Comment 6•15 years ago
|
||
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".
In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body contains places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.
Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.
Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in
before you can comment on or make changes to this bug.
Description
•