Closed
Bug 391643
Opened 17 years ago
Closed 17 years ago
Remove GetAlphaBytesPerRow from imgContainer.cpp
Categories
(Core :: Graphics: ImageLib, defect)
Core
Graphics: ImageLib
Tracking
()
VERIFIED
FIXED
mozilla1.9beta1
People
(Reporter: alfredkayser, Assigned: alfredkayser)
References
()
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
tor
:
superreview+
pavlov
:
approval1.9+
|
Details | Diff | Splinter Review |
GetAlphaBytesPerRow doesn't make sense in the Cairo based image handling, and imgContainer only uses it to test for transparancy. Better is to check the format for that.
Attachment #276091 -
Flags: superreview?(tor)
Attachment #276091 -
Flags: review?(pavlov)
|
||
Updated•17 years ago
|
Attachment #276091 -
Flags: review?(pavlov) → review+
|
Assignee | |
Comment 2•17 years ago
|
||
Attachment #276091 -
Attachment is obsolete: true
Attachment #277500 -
Flags: superreview?(tor)
Attachment #277500 -
Flags: approval1.9?
Attachment #276091 -
Flags: superreview?(tor)
Attachment #277500 -
Flags: superreview?(tor) → superreview+
|
|
Assignee | |
Updated•17 years ago
|
Keywords: checkin-needed
|
||
Comment 3•17 years ago
|
||
Don't you need approval1.9 before you need checkin-needed?
Keywords: checkin-needed
|
|
Assignee | |
Comment 4•17 years ago
|
||
This patch is needed to fix bug 367281, to get rid of the ugly
GetAlphaBytesPerRow from gfxImageFrame. GetAlphaBytesPerRow doesn't
work as expected in the Cairo based Gecko 1.9, and it
would be wrong to keep this method exposed in the official Gecko 1.9 release.
Flags: blocking1.9?
|
|
||
Updated•17 years ago
|
Attachment #277500 -
Flags: approval1.9? → approval1.9+
|
|
||
Updated•17 years ago
|
Flags: blocking1.9? → blocking1.9-
|
|
Assignee | |
Updated•17 years ago
|
Keywords: checkin-needed
|
||
Comment 5•17 years ago
|
||
Checking in modules/libpr0n/src/imgContainer.cpp;
/cvsroot/mozilla/modules/libpr0n/src/imgContainer.cpp,v <-- imgContainer.cpp
new revision: 1.52; previous revision: 1.51
done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M9
You need to log in
before you can comment on or make changes to this bug.
Description
•