Closed Bug 39250 Opened 24 years ago Closed 6 years ago

Form controls don't look good in 8-bit

Categories

(Core :: Layout: Form Controls, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED WONTFIX
Future

People

(Reporter: sitsofe, Unassigned)

Details

This is split from bug 4762. Input boxes and some other form controls are missing the bottom underline when viewing in 8-bit colour on linux. See http://bugzilla.mozilla.org/showattachment.cgi?attach_id=8266 for a ong screenshot. Build id: 051308 Linux
This is a Gecko/HTML form control issue. Reassigning to rods@netscape.com.
Assignee: bdonohoe → rods
Component: User Interface: Design Feedback → HTML Form Controls
setting to M17
Status: NEW → ASSIGNED
Target Milestone: --- → M17
This bug has been marked "future" because at this time it has been determined that it is not absolutely critical for RTM (Release To Manufacturing). If the reporter and anyone else believe it is necessary to fix this before shipping Seamonkey 1.0, please describe your issue in the bug.
Target Milestone: M17 → Future
[Setting QA contact for this component]
QA Contact: mpt → bsharma
QA Contact Update
QA Contact: bsharma → vladimire
Priority: P3 → --
So the problem here is that the light gray just gets dithered to white, right? I'm not sure there is anything we can do here without making form controls look worse in 16+ bit color...
Boris Zbarsky wrote: > So the problem here is that the light gray just gets dithered to white, right? > I'm not sure there is anything we can do here without making form controls > look worse in 16+ bit color... Well, one possible solution would be to first allocate colors for form controls instead of hardcoding RGB values in layout and then the RGB color cube for other, more generic purposes... this would need a new API in gfx to obtain the color values for "light color", "shadow color", "highlight color", etc, following the implementation of AmigaOS>=2.0 (which had a very good-looking GUI interface even for 4bit screens ("only" 16 colors!!)). If anyone is interested I can come-up with a full spec what's needed to implement this correctly.
Well, right now we just say we want an "inset ThreeDFace" border. No hardcoded rgb anywhere. We get the value of ThreeDFace from gfx, then use nsCSSRendering::MakeBevelColor to create the border colors (with the last arg set to true in this case). The problem is that the resulting color depends on the background color, not just the border color... so I'm not sure what sort of simple API would do here.
One could modify Gfx to massage the CSS system colors to make them look good in 8-bit color. I think that's probably the way to go.
Assignee: rods → nobody
Status: ASSIGNED → NEW
QA Contact: vladimire → layout.form-controls
8-bit color doesn't seem like something we should spend time on...
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.