Closed
Bug 392614
Opened 17 years ago
Closed 17 years ago
Assertion typing in URL bar
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
People
(Reporter: bzbarsky, Assigned: surkov)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
aaronlev
:
review+
damons
:
approval1.9+
|
Details | Diff | Splinter Review |
I get this all the time while typing in the URL bar in Seamonkey:
###!!! ASSERTION: Never ran into the same child that we started from: 'sibling', file ../../../../mozilla/accessible/src/base/nsAccessible.cpp, line 825
Makes debugging suck. A lot. Please fix.
Flags: blocking1.9?
Comment 1•17 years ago
|
||
Needs s/DEBUG/DEBUG_A11Y
Comment 2•17 years ago
|
||
Attachment #277107 -
Flags: review?(bzbarsky)
Attachment #277107 -
Flags: approval1.9?
Reporter | ||
Comment 3•17 years ago
|
||
Uh... this doesn't fix the bug I filed. That fixes the e-mail I sent you, but that's not what this bug is about. Not that this is a bad change, mind you. ;)
Comment 4•17 years ago
|
||
Ginn or Evan, can you take a look at this?
Assignee: aaronleventhal → ginn.chen
Updated•17 years ago
|
Attachment #277107 -
Attachment is obsolete: true
Attachment #277107 -
Flags: review?(bzbarsky)
Attachment #277107 -
Flags: approval1.9?
like a dupe of bug 390414
when deleting the last character in text entry, because we fire delete event after the text node was deleted, we can't find the child in GetIndexInParent(), then get the assertion failed.
Comment 7•17 years ago
|
||
Surkov, is this fixed by your patch in bug 393094?
Assignee: ginn.chen → surkov.alexander
Assignee | ||
Comment 8•17 years ago
|
||
(In reply to comment #7)
> Surkov, is this fixed by your patch in bug 393094?
>
Really I can't reproduce the bug event without patch. I tried all seamonkeys I have.
Comment 9•17 years ago
|
||
I don't need Seamonkey.
Just Firefox trunk, backspace in URL bar until last char is deleted.
Comment 10•17 years ago
|
||
Also, I was on Windows when I got the assertion.
OS: Linux → All
Hardware: PC → All
Assignee | ||
Comment 11•17 years ago
|
||
I built trunk firefox, inabled ally by starting DOMi events viewer, removed all text from address bar by backspace and I see events from addressbar but I do not see any assertion.
Assignee | ||
Comment 12•17 years ago
|
||
I get an assertion, though it looks another one. Stack trace is:
> accessibility.dll!nsHyperTextAccessible::DOMPointToHypertextOffset(nsIDOMNode * aNode=0x06505870, int aNodeOffset=0xffffffff, int * aHyperTextOffset=0x0012e724, nsIAccessible * * aFinalAccessible=0x0012e728, int aIsEndOffset=0x00000000) Line 659 + 0x12 C++
accessibility.dll!nsDocAccessible::CreateTextChangeEventForNode(nsIAccessible * aContainerAccessible=0x0650c3c4, nsIDOMNode * aChangeNode=0x06505870, nsIAccessible * aAccessibleForChangeNode=0x0650595c, int aIsInserting=0x00000000, int aIsAsynch=0x00000000) Line 1324 + 0x33 C++
accessibility.dll!nsDocAccessible::InvalidateCacheSubtree(nsIContent * aChild=0x06505850, unsigned int aChangeEventType=0x00000002) Line 1774 + 0x33 C++
accessibility.dll!nsAccessibilityService::InvalidateSubtreeFor(nsIPresShell * aShell=0x044f0cc8, nsIContent * aChangeContent=0x06505850, unsigned int aEvent=0x00000002) Line 1834 + 0x1f C++
gklayout.dll!nsGenericElement::doRemoveChildAt(unsigned int aIndex=0x00000000, int aNotify=0x00000001, nsIContent * aKid=0x06505850, nsIContent * aParent=0x053cd678, nsIDocument * aDocument=0x00dbd798, nsAttrAndChildArray & aChildArray={...}) Line 2721 C++
gklayout.dll!nsGenericElement::RemoveChildAt(unsigned int aIndex=0x00000000, int aNotify=0x00000001) Line 2692 + 0x2a C++
The problem is DOMPointToHypertextOffset() doesn't return an accessible when latest text node is removed (see http://lxr.mozilla.org/mozilla/source/accessible/src/html/nsHyperTextAccessible.cpp#661) and we get an assertion "Hypertext is reporting a different accessible for this node" (see http://lxr.mozilla.org/mozilla/source/accessible/src/base/nsDocAccessible.cpp#1354)
Aaron, can you clarify this condition from DOMPointToHypertextOffset?
Comment 13•17 years ago
|
||
That's what is returned when the offset is at the very end of the text.
Just change the assertion from
NS_ASSERTION(changeAccessible == aAccessibleForChangeNode,
to
NS_ASSERTION(!changeAccessible || changeAccessible == aAccessibleForChangeNode,
Updated•17 years ago
|
Attachment #281773 -
Flags: review?(aaronleventhal) → review+
Assignee | ||
Updated•17 years ago
|
Attachment #281773 -
Flags: approval1.9?
Updated•17 years ago
|
Attachment #281773 -
Flags: approval1.9? → approval1.9+
Assignee | ||
Comment 15•17 years ago
|
||
checked in
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•