Closed Bug 392820 Opened 17 years ago Closed 17 years ago

Bookmarks "star" panel should capture keyboard shortcuts

Categories

(Firefox :: Bookmarks & History, defect)

x86
macOS
defect
Not set
major

Tracking

()

VERIFIED FIXED
Firefox 3 alpha8

People

(Reporter: jruderman, Assigned: asaf)

References

Details

(Keywords: access)

Attachments

(1 file)

Steps to reproduce: 1. Click the bookmark star on a page that is already bookmarked. 2. Press Esc. Expected: the panel should close. Result: nothing happens. 3. Press Cmd+W. Expected: the panel should close. Result: the browser tab closes!!! (But the panel remains!) It captures mouse clicks outside of itself, so it should capture keyboard shortcuts too. (That includes Cmd+T, Cmd+], etc.)
Flags: blocking-firefox3?
Assignee: nobody → mano
I think this is a known bug with panels. IMO Cmd+W should be a no-op, this isn't a window.
Flags: blocking-firefox3? → blocking-firefox3+
(In reply to comment #1) > I think this is a known bug with panels. IMO Cmd+W should be a no-op, this > isn't a window. > I agree wrt to Cmd+W. However, Esc (or some other intuitive shortcut) should close the panel.
Target Milestone: --- → Firefox 3 M8
Version: Trunk → 1.0 Branch
Version: 1.0 Branch → Trunk
Attached patch some improvements (deleted) — Splinter Review
* block accel+w/accel+shift+w * close the panel on enter/esc * focus the name-field/picker and select its contents when opening the panel. * focus the content-area when the panel is closed.
Attachment #278830 - Flags: review?(dietrich)
> focus the content-area when the panel is closed. It would be better to return focus to where it was before you clicked the star or pressed Cmd+D. This would be more in line with how dialogs work.
Jesse: please file a follow once I land this patch, implementing that may not be trivial given the current double-click+popup interaction.
Attachment #278830 - Flags: review?(dietrich) → review+
mozilla/browser/base/content/browser-places.js 1.47
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
verified with - Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a8pre) Gecko/2007091304 Minefield/3.0a8pre
Status: RESOLVED → VERIFIED
I filed bug 402499 on the restoring-focus issue (comment 6).
Blocks: 409155
It looks like this caused bug 409155
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h". In Thunderbird 3.0b, you do that as follows: Tools | Message Filters Make sure the correct account is selected. Click "New" Conditions: Body contains places-to-b-and-h Change the action to "Delete Message". Select "Manually Run" from the dropdown at the top. Click OK. Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter. Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
Depends on: 1468077
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: