Closed
Bug 393630
Opened 17 years ago
Closed 17 years ago
Potential crash on oom in GenerateAlternativeString
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9beta1
People
(Reporter: sharparrow1, Assigned: masayuki)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
pavlov
:
review+
damons
:
approval1.9+
|
Details | Diff | Splinter Review |
From bug 341500 comment 24:
(In reply to comment #23)
> (In reply to comment #20)
> > Created an attachment (id=247329) [edit] [details]
> > Replace the surrogate pair at disabling the shaping
> > Another approach, how about this?
>
> | + mAlternativeString = (PRUnichar *)malloc(mLength *
> sizeof(PRUnichar));
> | + memcpy((void *)mAlternativeString, (const void *)mString,
> | + mLength * sizeof(PRUnichar));
>
> This can cause crash on OOM.
>
Wow, you're right. I'll file and fix it.(after a business trip).
|
Assignee | |
Comment 1•17 years ago
|
||
Sorry, I forgot this. Thank you for your report.
Attachment #278435 -
Flags: review?(pavlov)
Attachment #278435 -
Flags: approval1.9?
|
|
Assignee | |
Updated•17 years ago
|
Status: NEW → ASSIGNED
|
||
Updated•17 years ago
|
Attachment #278435 -
Flags: review?(pavlov)
Attachment #278435 -
Flags: review+
Attachment #278435 -
Flags: approval1.9?
Attachment #278435 -
Flags: approval1.9+
|
|
||
Updated•17 years ago
|
Attachment #278435 -
Flags: approval1.9+ → approval1.9?
|
||
Updated•17 years ago
|
Attachment #278435 -
Flags: approval1.9? → approval1.9+
|
|
||
Updated•17 years ago
|
Keywords: checkin-needed
|
||
Comment 2•17 years ago
|
||
Checking in gfx/thebes/src/gfxWindowsFonts.cpp;
/cvsroot/mozilla/gfx/thebes/src/gfxWindowsFonts.cpp,v <-- gfxWindowsFonts.cpp
new revision: 1.154; previous revision: 1.153
done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M9
|
|
Assignee | |
Comment 3•17 years ago
|
||
Oops, thank you for your checking-in.
You need to log in
before you can comment on or make changes to this bug.
Description
•