Closed Bug 393649 Opened 17 years ago Closed 17 years ago

[FIX]"ASSERTION: assigning special sibling to other than first-in-flow!" with -moz-column, block-in-inline

Categories

(Core :: Layout, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla1.9alpha8

People

(Reporter: jruderman, Assigned: bzbarsky)

References

Details

(Keywords: assertion, regression, testcase)

Attachments

(3 files)

Attached file testcase (deleted) —
Loading the testcase triggers:

###!!! ASSERTION: assigning special sibling to other than first-in-flow!: '!aFrame->GetPrevInFlow()', file /Users/jruderman/trunk/mozilla/layout/base/nsCSSFrameConstructor.cpp, line 490

The final layout is consistent with the same DOM loaded as markup, but Find for the inserted text is broken when the bug is triggered.  I took advantage of that by calling find() in order to make a reftest pair.
Attached file reference (deleted) —
In the reference, "XXX" is selected correctly, but in the testcase, it isn't (due to the bug that causes the assertion to fire, I'm guessing).
Attached patch Fix (deleted) — Splinter Review
Jesse, that is a _nice_ test!
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #278165 - Flags: superreview?(roc)
Attachment #278165 - Flags: review?(roc)
OS: Mac OS X → All
Priority: -- → P1
Hardware: PC → All
Summary: "ASSERTION: assigning special sibling to other than first-in-flow!" with -moz-column, block-in-inline → [FIX]"ASSERTION: assigning special sibling to other than first-in-flow!" with -moz-column, block-in-inline
Target Milestone: --- → mozilla1.9 M8
Attachment #278165 - Flags: superreview?(roc)
Attachment #278165 - Flags: superreview+
Attachment #278165 - Flags: review?(roc)
Attachment #278165 - Flags: review+
Comment on attachment 278165 [details] [diff] [review]
Fix

Very safe regression fix.
Attachment #278165 - Flags: approval1.9?
Comment on attachment 278165 [details] [diff] [review]
Fix

a1.9=dbaron
Attachment #278165 - Flags: approval1.9? → approval1.9+
Fixed.  Test checked in.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
The tests were checked in as .html files.  I think they should have been checked in as .xhtml, since they use div inside span (the HTML parser doesn't like that).
Uh... no.  The HTML parser allows <div> inside <span> just fine.  I tested with the testcases I checked in before and after the patch, of course.
Oh, interesting.  It does strange things with <div> inside <b>, but it leaves <div> inside <span> alone.
Yep.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: