Closed
Bug 393819
Opened 17 years ago
Closed 17 years ago
Assertion: What's this case?: 'result == 0 || result == 1' in gfxFontconfigUtils when different fonts have a common family name
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: karlt, Assigned: karlt)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
pavlov
:
review+
pavlov
:
approval1.9+
|
Details | Diff | Splinter Review |
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/gfx/thebes/src/gfxFontconfigUtils.cpp&rev=1.5&mark=419-426,449#419
When a group of fonts have a common family name, but differing lists of family names, this assertion fires. (A font can have more than one family name.)
e.g.
(gdb) p fs->nfont
$14 = 3
(gdb) p FcPatternPrint(fs->fonts[0])
Pattern has 1 elts (size 16)
family: "Arial"(s) "Arial Narrow"(s)
$16 = 10
(gdb) p FcPatternPrint(fs->fonts[1])
Pattern has 1 elts (size 16)
family: "Arial"(s) "Arial Black"(s)
$17 = 10
(gdb) p FcPatternPrint(fs->fonts[2])
Pattern has 1 elts (size 16)
family: "Arial"(s)
$18 = 10
I think the assertion can just be removed, as the code is successfully detecting that we have at least one match (and the specific match out of the three can be determined later).
Assignee | ||
Comment 1•17 years ago
|
||
Attachment #278372 -
Flags: review?(pavlov)
Comment 2•17 years ago
|
||
I think that IsExistingFont should return 1 at that time. Because, when the name is cached, we cannot return the actual count.
Assignee | ||
Comment 3•17 years ago
|
||
Returning 1 seems consistent.
Attachment #278372 -
Attachment is obsolete: true
Attachment #278388 -
Flags: review?(pavlov)
Attachment #278372 -
Flags: review?(pavlov)
Updated•17 years ago
|
Attachment #278388 -
Flags: review?(pavlov)
Attachment #278388 -
Flags: review+
Attachment #278388 -
Flags: approval1.9+
Assignee | ||
Updated•17 years ago
|
Keywords: checkin-needed
Comment 4•17 years ago
|
||
checked-in, thanks!
You need to log in
before you can comment on or make changes to this bug.
Description
•