Closed
Bug 394484
Opened 17 years ago
Closed 17 years ago
Star icon in url autocomplete results shouldn't be set for items in RSS / Live Bookmarks.
Categories
(Firefox :: Bookmarks & History, defect)
Firefox
Bookmarks & History
Tracking
()
VERIFIED
FIXED
Firefox 3 alpha8
People
(Reporter: moco, Assigned: moco)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
moco
:
review+
|
Details | Diff | Splinter Review |
Star icon in url autocomplete results shouldn't be set for items in RSS / Live Bookmarks.
see also bug #393887
fix in hand.
Flags: in-litmus?
Flags: blocking-firefox3?
Assignee | ||
Comment 1•17 years ago
|
||
Attachment #279149 -
Flags: review?(dietrich)
Comment 2•17 years ago
|
||
Comment on attachment 279149 [details] [diff] [review]
patch
>
>+ nsCString sql = NS_LITERAL_CSTRING(
>+ "SELECT annos.item_id FROM moz_anno_attributes attrs "
>+ "JOIN moz_items_annos annos WHERE attrs.name = \"livemark/feedURI\" "
please put that in a const, as we do with other annotation names. r=me otherwise, thanks!
Attachment #279149 -
Flags: review?(dietrich) → review+
Assignee | ||
Comment 3•17 years ago
|
||
Attachment #279149 -
Attachment is obsolete: true
Attachment #279189 -
Flags: review+
Assignee | ||
Comment 4•17 years ago
|
||
fixed.
Checking in toolkit/components/places/src/nsNavHistory.cpp;
/cvsroot/mozilla/toolkit/components/places/src/nsNavHistory.cpp,v <-- nsNavHis
tory.cpp
new revision: 1.158; previous revision: 1.157
done
Checking in toolkit/components/places/src/nsNavHistory.h;
/cvsroot/mozilla/toolkit/components/places/src/nsNavHistory.h,v <-- nsNavHisto
ry.h
new revision: 1.94; previous revision: 1.93
done
Checking in toolkit/components/places/src/nsNavHistoryAutoComplete.cpp;
/cvsroot/mozilla/toolkit/components/places/src/nsNavHistoryAutoComplete.cpp,v <
-- nsNavHistoryAutoComplete.cpp
new revision: 1.17; previous revision: 1.16
done
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Comment 5•17 years ago
|
||
Just to be clear again:
This is intending for the URLS in any given XML / live bookmark feed URL to NOT be marked as favorited (since we suck them in under their parent), but that their parent (such as http://weblogs.mozillazine.org/asa/index.rdf, which I've verified in other bugs as showing the gold star in both autocomplete and the URL bar once the page has loaded) SHOULD, yes?
(If so, I can totally write the STR for Litmus and bug verification.)
Comment 6•17 years ago
|
||
Sorry for the lame question; I'm already clear:
http://litmus.mozilla.org/show_test.cgi?id=4683
in-litmus+
And, verified FIXED using:
Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a8pre) Gecko/2007091204 Minefield/3.0a8pre
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a8pre) Gecko/2007091104 Minefield/3.0a8pre
and
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a8pre) Gecko/2007091204 Minefield/3.0a8pre
Status: RESOLVED → VERIFIED
Flags: in-litmus? → in-litmus+
Updated•17 years ago
|
Flags: blocking-firefox3? → blocking-firefox3+
Comment 7•15 years ago
|
||
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".
In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body contains places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.
Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.
Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in
before you can comment on or make changes to this bug.
Description
•