Closed
Bug 394635
Opened 17 years ago
Closed 17 years ago
Make about: look reasonable in trunk modern theme
Categories
(SeaMonkey :: General, defect)
SeaMonkey
General
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.0a1
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
neil
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
We need some styling for 'about:' in the modern theme as currently it looks awful.
I suggest just re-using the css file from toolkit's winstripe theme as that looks reasonable (and will match our classic version). Btw, about.css for the about: page is only present in the winstripe theme.
Attachment #279317 -
Flags: superreview?(neil)
Attachment #279317 -
Flags: review?(neil)
|
||
Comment 1•17 years ago
|
||
Comment on attachment 279317 [details] [diff] [review]
Re-use toolkit's about.css in modern
No, about.css should match netError.css and config.css
Attachment #279317 -
Flags: superreview?(neil)
Attachment #279317 -
Flags: superreview-
Attachment #279317 -
Flags: review?(neil)
|
Assignee | |
Comment 2•17 years ago
|
||
I've redone toolkit's about.css so that it has the look and feel of netError.css (config.css didn't seem too relevant). Alongside that I've done some minor re-arrangement of the borders and version text, so it should fit better on a 800x600 display, and also looks a lot better overall.
Attachment #279317 -
Attachment is obsolete: true
Attachment #280386 -
Flags: superreview?(neil)
Attachment #280386 -
Flags: review?(neil)
|
|
||
Comment 3•17 years ago
|
||
Comment on attachment 280386 [details] [diff] [review]
Supply an about.css file
Ah yes, config's opening screen is XUL, not HTML (but the borders and colours should be the same!)
Attachment #280386 -
Flags: superreview?(neil)
Attachment #280386 -
Flags: superreview+
Attachment #280386 -
Flags: review?(neil)
Attachment #280386 -
Flags: review+
|
|
Assignee | |
Comment 4•17 years ago
|
||
I checked this in yesterday -> fixed.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
||
Updated•17 years ago
|
Target Milestone: --- → seamonkey2.0alpha
You need to log in
before you can comment on or make changes to this bug.
Description
•