Closed Bug 395062 Opened 17 years ago Closed 17 years ago

Identity popup doesn't show on first click of session

Categories

(Firefox :: General, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED

People

(Reporter: johnath, Assigned: johnath)

References

Details

Attachments

(1 file)

The identity-popup in browser.xul is constructed with hidden=true to prevent frame allocation as part of browser startup. The onmouseup handler on the identity-box element unhides the popup before showing, but the first time this happens, the call to openPopup() doesn't result in the popup being displayed, since the popup hasn't be built yet. Neil & Gavin suggest 3 possible fixes: 1) Wrap the openPopup call in a setTimeout() so that the function returns before openPopup is called, and the popup has time to build itself 2) Attempt to access the box object in some way, e.g. by asking for the popup's width, which should trigger relayout as a side effect 3) Wait for bug 394887, which may make it unnecessary to hide the popup for performance reasons in the first place. #3 is obviously the most appealing.
Depends on: larry
Attached patch Simple setTimeout approach (deleted) — Splinter Review
Litmus triage team: Tomcat will add Litmus test case
Looks like this isn't needed anymore since bug 394887 was fixed. If so, please resolve appropriately.
No longer depends on: larry
Blocks: larry
I confirm that this appears resolved on trunk for mac and windows - resolving.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a9pre) Gecko/2007102402 Minefield/3.0a9pre ID:2007102402 VERIFIED
Status: RESOLVED → VERIFIED
Flags: in-litmus? → in-litmus+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: