Closed Bug 395122 Opened 17 years ago Closed 17 years ago

Toolbar customization sheet is broken

Categories

(Firefox :: General, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 3 alpha8

People

(Reporter: asaf, Assigned: asaf)

References

Details

Attachments

(1 file)

Attached patch tentative patch (deleted) — Splinter Review
Since FDL landed on trunk, chrome-on-content stacks have regressed in ways which break the toolbar customization sheet whenever a page is loaded. We'll experience using a panel here instead.

I'll log a follow up for moving the panel when the browser window is moved.
Attachment #279832 - Flags: review?(mconnor)
Depends on: 395123
Flags: blocking-firefox3?
I wonder if removing the <stack> could break any extensions. But then you are saying the using the stack for "chrome-over-content" is busted anyways.
Comment on attachment 279832 [details] [diff] [review]
tentative patch

r=me
Attachment #279832 - Flags: review?(mconnor) → review+
Comment on attachment 279832 [details] [diff] [review]
tentative patch

Going to approve this so we can actually test toolbar cust sanely in M8
Attachment #279832 - Flags: approval1.9+
Checking in browser/base/content/browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.841; previous revision: 1.840
done
Checking in browser/base/content/browser.xul;
/cvsroot/mozilla/browser/base/content/browser.xul,v  <--  browser.xul
new revision: 1.369; previous revision: 1.368
done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Depends on: 395334
Flags: blocking-firefox3? → blocking-firefox3+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: