Closed
Bug 395205
Opened 17 years ago
Closed 17 years ago
http code doesn't correctly check whether it is resuming
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla1.9beta1
People
(Reporter: Biesinger, Assigned: Biesinger)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
Biesinger
:
review+
dmosedale
:
superreview+
|
Details | Diff | Splinter Review |
nsHttpChannel::OpenCacheEntry checks for the presence of a Range header. However, that header is not set for nsIResumableChannel-initiated range requests at this point - it's only set in SetupTransaction. Therefore, we could open a cache entry even though we should be resuming.
Flags: blocking1.9?
|
Assignee | |
Comment 1•17 years ago
|
||
Attachment #279909 -
Flags: superreview?(bzbarsky)
Attachment #279909 -
Flags: review?(bzbarsky)
|
||
Comment 2•17 years ago
|
||
This works correctly for me.
|
||
Comment 3•17 years ago
|
||
Comment on attachment 279909 [details] [diff] [review]
patch
sr=dmose, in case we find a reviewer for this who can't also sr.
Attachment #279909 -
Flags: superreview?(bzbarsky) → superreview+
|
||
Comment 4•17 years ago
|
||
Comment on attachment 279909 [details] [diff] [review]
patch
looks good to me! r/sr=me
|
|
Assignee | |
Comment 5•17 years ago
|
||
Comment on attachment 279909 [details] [diff] [review]
patch
safe patch to correctly support resuming downloads when the file is (partially or fully) cached
Attachment #279909 -
Flags: review?(bzbarsky)
Attachment #279909 -
Flags: review+
Attachment #279909 -
Flags: approval1.9?
|
||
Updated•17 years ago
|
Flags: blocking1.9? → blocking1.9+
|
|
||
Comment 6•17 years ago
|
||
Comment on attachment 279909 [details] [diff] [review]
patch
This doesn't need approval because it is blocking+.
This can land once the tree opens.
Attachment #279909 -
Flags: approval1.9?
|
|
Assignee | |
Comment 7•17 years ago
|
||
Checking in netwerk/protocol/http/src/nsHttpChannel.cpp;
/cvsroot/mozilla/netwerk/protocol/http/src/nsHttpChannel.cpp,v <-- nsHttpChannel.cpp
new revision: 1.321; previous revision: 1.320
done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•17 years ago
|
Target Milestone: mozilla1.9 M8 → mozilla1.9 M9
You need to log in
before you can comment on or make changes to this bug.
Description
•