u88484 Assignee
	Description • 17 years ago

Sorry about the title but I was having a brain fart.

1) type about:config in location bar; hit enter
2) the input box has focus, select any entry in the list
3) a black box appears around the list
4) click back in the input box and the black box disappears

	u88484 Assignee
	Comment 2 • 17 years ago

Alrighty I found where it came from and I guess I just never noticed it before...but now that I do it is annyoing. Is is there because of a class for the tree "plain focusring".  

http://lxr.mozilla.org/mozilla/source/toolkit/components/viewconfig/content/config.xul#101

No other trees in Firefox have this so is it alright for me to create a patch for this or would I just be wasting my time?

	u88484 Assignee
	Comment 3 • 17 years ago

I always hit commit and think of stuff right after wards.  This class="plain focusring" was added back when the warning dialog was added to the about:config

1.9  cst%yecc.com  2006-12-04 16:15  Bug 339720 show warning page before showing about:config (toolkit version)  r=mano

	Chris Thomas (CTho) [formerly cst@andrew.cmu.edu cst@yecc.com]
	Comment 4 • 17 years ago

It's part of XPFE accessibility.  I don't know why toolkit dropped the focusrings.

	neil@parkwaycc.co.uk
	Comment 5 • 17 years ago

Personally I think that the automatic "set current index to topmost visible row" is much more annoying than the focus ring.

	u88484 Assignee
	Comment 6 • 17 years ago

Not sure what you mean there but if you look in the options menu:
Aplication tab...no focus ring
Content tab, the first two exceptions and advanced windows...no focus ring
Privacy tab -> Cookies -> exceptions or show cookies...no focus ring
Security tab, the addons exceptions, password exceptions and show passwords...no focus ring
Advanced -> Encryption, view certification and revocation list...no focus ring

The about:config is the only one with a focus ring around it, should be removed for consistency.  If there for accessibility, none of the above mentioned have it or need it because the huge blue background provide enough indication of what has focus.

  

	Dão Gottwald [:dao]
	Comment 8 • 16 years ago

(In reply to comment #2)
> No other trees in Firefox have this so is it alright for me to create a patch
> for this or would I just be wasting my time?

Go ahead. Bug 339720 doesn't seem to explain why this was added.

	u88484 Assignee
	Comment 9 • 16 years ago

Patch removing class="plain focusring"

	Markus Stange [:mstange]
	Comment 10 • 16 years ago

Removing the class "plain" is also good for bug 465402 (otherwise the tree header cells wouldn't have any top border on OS X).

	u88484 Assignee
	Comment 11 • 16 years ago

Removed keyword 'checkin-needed'. Sorry, didn't know we needed to get approval now.

	Mike Beltzner [:beltzner, not reading bugmail]
	Comment 12 • 16 years ago

Comment on attachment 340343 [details] [diff] [review]
Patch

a191=beltzner - thanks; I hate this focusring.

	Shawn Wilsher :sdwilsh
	Comment 14 • 16 years ago

http://hg.mozilla.org/mozilla-central/rev/ef9271b79eab

	Aakash Desai [:aakashd]
	Comment 15 • 15 years ago

pushed http://hg.mozilla.org/releases/mozilla-1.9.1/rev/ef9271b79eab

verified FIXED on builds: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090511 Minefield/3.6a1pre ID:20090511031307

and

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b5pre) Gecko/20090511 Shiretoko/3.5b5pre ID:20090511031352