Closed Bug 396196 Opened 17 years ago Closed 11 years ago

Use wrapper executable with no extra options for OS Integration

Categories

(Firefox :: Shell Integration, defect)

defect
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: dveditz, Unassigned)

References

Details

(Keywords: sec-want, Whiteboard: [sg:want P2])

As seen in the various inter-program URI-launching problems recently (bug 384384 mitigated by adding -osint, bug 395942 quicktime ignoring the -osint addition) we should create a launcher program for OS Integration that does not take extra arguments beyond the minimum necessary to load a URI. That wrapper can then call the real firefox executable with the -osint -url "%s" params, and any other code building on our platform can call the internal exe if they need the -chrome param or other fancy stuff. Spun off from bug 395942 comment 7 and later discussion.
Flags: blocking-firefox3?
Whiteboard: [sg:want P2]
passing arbitrary arguments is dangerous on linux. shouldn't os be all?
Yeah; changing to all/all.
OS: Windows XP → All
Hardware: PC → All
Mike: we need an owner here, and please make this block Firefox 3
Assignee: nobody → mconnor
Flags: blocking-firefox3? → blocking-firefox3+
Target Milestone: --- → Firefox 3 M11
Priority: -- → P5
Would like to see this, but I wonder if its too late to muck with this for Fx3. Jim, thoughts?
Assignee: mconnor → jmathies
Flags: wanted-firefox3+
Flags: blocking-firefox3-
Flags: blocking-firefox3+
Target Milestone: Firefox 3 Mx → Firefox 3 M11
Well, imho, it feels like a pretty big change to make at beta 2. But once I finish up my other higher priority bugs I can try to roll something together. From my understanding this would touch on the installer, all the application registration stuff in firefox, and in some places some of the new helper app handling code which filters the running app out of helper app registrations. Am I missing anything?
Beta3 is over. Removing TM.
Target Milestone: Firefox 3 beta3 → ---
Version: unspecified → Trunk
Blocks: 369052
Blocks: 266533
Blocks: 392155
Assignee: jmathies → nobody
No longer blocks: 266533
Flags: wanted-firefox3.1?
Priority: P5 → --
Daniel, how important is this bug for security these days? Is it still wanted after 5 years?
Flags: wanted-firefox3.5? → needinfo?(dveditz)
This was an attempt to protect us from misbehaving apps like QuickTime (see bug 395942), but if an application is doing its own thing they might work around such a wrapper anyways.
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: needinfo?(dveditz)
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.