Closed
Bug 396541
Opened 17 years ago
Closed 17 years ago
Show Passwords dialog/chrome is broken
Categories
(Firefox :: Settings UI, defect)
Tracking
()
RESOLVED
FIXED
Firefox 3 beta1
People
(Reporter: stevee, Assigned: robert.strong.bugs)
References
Details
(Keywords: regression)
Attachments
(2 files, 1 obsolete file)
(deleted),
image/png
|
Details | |
(deleted),
patch
|
mconnor
:
review+
mconnor
:
approval1.9+
|
Details | Diff | Splinter Review |
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a8pre) Gecko/2007091802 Minefield/3.0a8pre ID:2007091802 1. New profile, start firefox 2. Tools > Options > Security > Passwords > Show Passwords.. Expected: - A dialog showing my passwords (or lack of in the case of a new profile) Actual: - A silly looking dialog. It appears to be purely firefox chrome, in that there are no Windows decorations such as a titlebar, the maximize/minimize/close window icons, and no way of resizing the dialog.
Reporter | ||
Comment 1•17 years ago
|
||
Works as expected: - 20070917_1204_firefox-3.0a8pre.en-US.win32 Weirdness: - 20070917_1229_firefox-3.0a8pre.en-US.win32 Checkins to module PhoenixTinderbox between 2007-09-17 12:04 and 2007-09-17 12:28 : http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1190055840&maxdate=1190057339 Bug 394666 seems most likely.
Blocks: 394666
Flags: blocking-firefox3?
Comment 2•17 years ago
|
||
Here is link to image showing the lack of window frame for the Show passwords dialog: http://img218.imageshack.us/my.php?image=passworddialogyf5.jpg Also, when Show passwords window is maximized using Task Manager, it maximizes to edge of monitor screen despite the task bar. Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a8pre) Gecko/2007091716 Minefield/3.0a8pre ID:2007091716
Comment 3•17 years ago
|
||
Looks like the patch for bug 394666 didn't take into account "standalone" prefpanes.
Updated•17 years ago
|
OS: Windows 2000 → All
![]() |
Assignee | |
Comment 4•17 years ago
|
||
Assignee: nobody → robert.bugzilla
Status: NEW → ASSIGNED
![]() |
Assignee | |
Updated•17 years ago
|
Attachment #281344 -
Attachment description: patch → patch - only apply changes from bug 394666 when we have multiple panes
Attachment #281344 -
Flags: review?(mconnor)
![]() |
Assignee | |
Comment 5•17 years ago
|
||
Attachment #281344 -
Attachment is obsolete: true
Attachment #281398 -
Flags: review?(mconnor)
Attachment #281398 -
Flags: approval1.9?
Attachment #281344 -
Flags: review?(mconnor)
Comment 6•17 years ago
|
||
Comment on attachment 281398 [details] [diff] [review] better patch r+a=me, thanks!
Attachment #281398 -
Flags: review?(mconnor)
Attachment #281398 -
Flags: review+
Attachment #281398 -
Flags: approval1.9?
Attachment #281398 -
Flags: approval1.9+
![]() |
Assignee | |
Comment 7•17 years ago
|
||
Checked in to trunk Checking in mozilla/toolkit/content/widgets/preferences.xml; /cvsroot/mozilla/toolkit/content/widgets/preferences.xml,v <-- preferences.xml new revision: 1.64; previous revision: 1.63 done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Flags: blocking-firefox3?
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 M9
![]() |
Assignee | |
Updated•15 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•