Closed
Bug 396580
Opened 17 years ago
Closed 17 years ago
Fix guessSystemTimezone if no TZNAME is set
Categories
(Calendar :: Internal Components, defect)
Calendar
Internal Components
Tracking
(Not tracked)
RESOLVED
FIXED
0.7
People
(Reporter: Fallen, Assigned: Fallen)
Details
Attachments
(2 files)
|
(deleted),
patch
|
Fallen
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
mvl
:
review+
|
Details | Diff | Splinter Review |
Quote RFC2445:
The optional "TZNAME" property is the customary name for the time
zone. It may be specified multiple times, to allow for specifying
multiple language variants of the time zone names. This could be used
for displaying dates.
Currently, guessSystemTimezone expects it to be there and tries to get the value as an ical string. This leads to exceptions in the views.
r=ctalbert as discussed
Attachment #281335 -
Flags: review+
|
Assignee | |
Comment 1•17 years ago
|
||
Checked in on HEAD and MOZILLA_1_8_BRANCH
-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
||
Comment 2•17 years ago
|
||
Comment on attachment 281335 [details] [diff] [review]
Fix guessSystemTimezone - v1
>- var standardName = standard.getFirstProperty("TZNAME").valueAsIcalString;
>+ var standardName = standard.getFirstProperty("TZNAME");
Please rename that to standardNameProp or some such, to indicate it's a component in the middle of a whole bunch of strings.
|
||
Updated•17 years ago
|
Target Milestone: --- → 0.7
|
|
Assignee | |
Comment 3•17 years ago
|
||
Attachment #281472 -
Flags: review?(mvl)
|
|
||
Comment 4•17 years ago
|
||
Comment on attachment 281472 [details] [diff] [review]
Additional patch
r=mvl
Attachment #281472 -
Flags: review?(mvl) → review+
|
|
Assignee | |
Comment 5•17 years ago
|
||
Additional patch checked in
You need to log in
before you can comment on or make changes to this bug.
Description
•