Closed Bug 396647 Opened 17 years ago Closed 13 years ago

GetDictionaryStringValue() should check the return value of SetLength()

Categories

(Firefox :: Migration, defect)

Product:
Firefox
Component:
Migration
Platform:
PowerPC
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WONTFIX

People

(Reporter: cpearce, Unassigned)

References

Details

User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-GB; rv:1.8.1.7) Gecko/20070914 Firefox/2.0.0.7 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-GB; rv:1.8.1.7) Gecko/20070914 Firefox/2.0.0.7 Patch 281128 for Bug 394691 showed up some bad coding in GetDictionaryStringValue() in browser/components/migration/src/nsSafariProfileMigrator.cpp; GetDictionaryStringValue() calls nsAutoTArray::SetLength() without checking to see if it succeeds or not. This patch highlighted some other places where the return value of SetLength() was not checked, we need to track them down and ensure they do sensible things upon failure. Reproducible: Always Steps to Reproduce: 1. 2. 3.
Status: UNCONFIRMED → NEW
Component: General → Migration
Ever confirmed: true
QA Contact: general → migration
the Safari migrator has been rewritten in js, so this doesn't apply anymore.
Status: NEW → RESOLVED
Closed: 13 years ago
Depends on: 710259
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.