Closed Bug 39724 Opened 25 years ago Closed 23 years ago

XBM mime type ignored

Categories

(Core :: Graphics: ImageLib, defect, P3)

All
Other
defect

Tracking

()

VERIFIED WORKSFORME

People

(Reporter: neil, Assigned: Biesinger)

References

()

Details

Attachments

(1 file)

When a data stream begins "#define " its mime type is set to "unknown." This is because sniffout_mimetype returns PR_TRUE overriding the server type. I assume this will prevent any future XBM decoder from working.
No component is available for xbm yet. Would you like to volunteer? The source for the xbm decoding is available. It just needs to be made into a component.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Target Milestone: --- → Future
Status: NEW → ASSIGNED
I was considering it... I'm not actually a C++ programmer although I do have some C and Java experience. Also my PC is a bit short on disk space at the moment...
Blocks: 61481
QA Contact: elig → tpreston
Blocks: 66962
Looking at the list of image filetypes/extenstions in layout/html/base/src/nsObjectFrame.cpp, it indicates the following extensions are supported: gif,jpg,png,xbm I am unable to load xbm files, and this looks like the cause. It seems ironic that IE5 has support. I am working on xpm support and it seems reasonable to get xbm to work at the same time, if its still a problem.
There should not be a hard coded list in layout about what image file formats are supported. It defeats the whole purpose of the design of the image lib. The current design allows you to add a new component fairly easily. There are some problems in other modules that make mapping the image file extension with the image type awkward. There is already a bug on this. And thanks for volunteering to create an XBM component. If you run into problems, let me know. -P
nsObjectFrame::IsSupportedImage, is where I found the hard coded list, and its used in nsObjectFrame::Init. Comments also indicate it "Ideally should be a call to imlib, when it is available" http://lxr.mozilla.org/seamonkey/source/layout/html/base/src/nsObjectFrame.cpp#3 87 Where would I find the source you mention for xbm decoding?
super. Let me dig out that old XBM code. -p
Attached file _very_ old source for xbm decoding (deleted) —
The attached code is _old_, but works. It needs an xpCOM wrapper. Take a look at the other decoder components (gif,jpg,png) and All Will Be Revealed. Also I poked around until I found code accessible via bonsai that has an early version of the com wrapper. You can find this at http://lxr.mozilla.org/classic/source/modules/libimg/src/xbm.cpp Happy Sailing! Feel free to assign this to yourself. -p
awww heck. I'll reassign it to you....
Assignee: pnunn → zeroJ
Status: ASSIGNED → NEW
Blocks: 73732
an important embedding customer wants support for XBM. Could we get it done by 6.1 RTM? clearing TM
Keywords: mozilla0.9.2
Target Milestone: Future → ---
Found a volunteer!
Assignee: zeroJ → cbiesinger
Keywords: mozilla0.9.8
Looks like the XBM Mimetype is not ignored. When a decoder is added in the usual way, it is used by imagelib. So only the actual decoder needs to be written, which is bug 8031. Marking WORKSFORME.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → WORKSFORME
Sounds good to me, marking verified
Status: RESOLVED → VERIFIED
The URL refers to libimg, I assume libpr0n doesn't have the same problem.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: