Robert Longson [:longsonr] Assignee
	Description • 17 years ago

Should only allow true and false as boolean arguments. 
Add validation along the lines of bug 383685 to catch things like

filter.preserveAlpha.baseVal = 56;

	Robert O'Callahan (:roc) (email my personal email if necessary)
	Comment 1 • 17 years ago

Well hang on, XPConnect should not be allowing scripts to set boolean attributes to non-boolean values. That's the real bug here. Right Blake?

	Blake Kaplan (:mrbkap) (inactive)
	Comment 2 • 17 years ago

Looking at the code, this patch should be unnecessary. Robert (Longson), can you test (e.g. by adding an assertion to nsSVGBoolean::SetBaseValue) to see if that's the case. If not, then XPConnect should be fixed.

It looks to me that bug 383685 arises because the xpidl+XPConnect type system isn't strong enough to catch invalid enumeration values. Boolean values are much easier to validate, however.

	Robert Longson [:longsonr] Assignee
	Comment 3 • 17 years ago

Comment on attachment 282378 [details] [diff] [review]
patch

withdrawing sr request while testing

	Robert Longson [:longsonr] Assignee
	Comment 4 • 17 years ago

I have to admit that despite my best efforts I can't break it :-) If we have the assert then others can try.

	Robert Longson [:longsonr] Assignee
	Comment 5 • 17 years ago

checked in.